407487 - Drop nsIAddressBook::abCardToEscapedVCard

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

I was just writing some documentation for nsIAddressBook.idl (for another bug) and came across this function:

string abCardToEscapedVCard(in nsIAbCard aCard);

All it does is to call aCard->ConvertToEscapedVCard(param) which happens to return a string as well...

Considering when I was documenting the function, I was thinking that the proper way is just to get the escaped vcard from the card itself, I think we can just drop this. There's two callers (one SM, one TB) and it'll save us getting the ab service in those instances (as well as the redundant call).

I also found an rv = x; return rv; combo to tidy up.

Comment 1

[Mark Banner (:standard8)]

Patch checked in -> fixed.