Closed Bug 407537 Opened 12 years ago Closed 4 years ago

NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file /Users/sayrer/dev/mozilla/xpcom/io/nsLocalFileOSX.cpp, line 451

Categories

(Core :: Networking: File, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: sayrer, Assigned: sayrer)

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

The sessionstore.js file doesn't exist the first time the service runs. nsSafeFileOutputStream shouldn't try to call Normalize() if the file doesn't exist.
Attachment #292259 - Flags: review?(enndeakin)
Attachment #292259 - Attachment is patch: true
Attachment #292259 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 292259 [details] [diff] [review]
check the exists boolean that's already there

Seems OK, but I'm not really the right person to review this
Attachment #292259 - Flags: review?(enndeakin) → review?(mano)
Attachment #292259 - Flags: review?(mano) → review?(cbiesinger)
Comment on attachment 292259 [details] [diff] [review]
check the exists boolean that's already there

so, r=biesi, but I'm not sure that this is the best fix. wouldn't it be better if nsLocalFileOSX didn't warn? For a nonexisting file it should, maybe, even follow the symlinks for the path components that do exist.
Attachment #292259 - Flags: review?(cbiesinger) → review+
Whiteboard: [necko-active]
https://hg.mozilla.org/mozilla-central/rev/a8a6133b6eeb
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.