Closed
Bug 407559
Opened 17 years ago
Closed 17 years ago
Allow XUL apps launched with Firefox to override name & vendor
Categories
(Toolkit Graveyard :: XULRunner, defect)
Toolkit Graveyard
XULRunner
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9beta3
People
(Reporter: mfinkle, Assigned: mfinkle)
Details
Attachments
(1 file, 1 obsolete file)
6.90 KB,
patch
|
benjamin
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
This is a follow on from bug 404134 which address launching XUL apps from xulrunner and xulrunner-stub. Since Firefox can also launch XUL apps, we should support the override behavior there too.
Attachment #292283 -
Flags: review?(benjamin)
Updated•17 years ago
|
Assignee: nobody → mark.finkle
Comment 1•17 years ago
|
||
Comment on attachment 292283 [details] [diff] [review] adds support for overriding parts of application.ini when launching a XUL app from Firefox mfinkle, can we just move the "-override" flag handling into XRE_main, so that all apps get it by default?
Updated•17 years ago
|
Attachment #292283 -
Flags: review?(benjamin)
Assignee | ||
Comment 2•17 years ago
|
||
This patch centralizes the override handling into XRE_main and removes the override handling added to nsXULStub.cpp and nsXULRunnerApp.cpp that was added in bug 404134.
Attachment #292283 -
Attachment is obsolete: true
Attachment #292637 -
Flags: review?(benjamin)
Updated•17 years ago
|
Attachment #292637 -
Flags: review?(benjamin) → review+
Assignee | ||
Updated•17 years ago
|
Attachment #292637 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #292637 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Updated•17 years ago
|
Keywords: checkin-needed
Comment 3•17 years ago
|
||
Checking in toolkit/xre/nsAppRunner.cpp; /cvsroot/mozilla/toolkit/xre/nsAppRunner.cpp,v <-- nsAppRunner.cpp new revision: 1.201; previous revision: 1.200 done Checking in xulrunner/app/nsXULRunnerApp.cpp; /cvsroot/mozilla/xulrunner/app/nsXULRunnerApp.cpp,v <-- nsXULRunnerApp.cpp new revision: 1.38; previous revision: 1.37 done Checking in xulrunner/stub/nsXULStub.cpp; /cvsroot/mozilla/xulrunner/stub/nsXULStub.cpp,v <-- nsXULStub.cpp new revision: 1.12; previous revision: 1.11 done
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
Comment 4•11 years ago
|
||
Hello guys, There is a problem with application.ini since Firefox/Thunderbird 11 and SeaMonkey 2.8. Can you read : https://bugzilla.mozilla.org/show_bug.cgi?id=723493 and resolve this bug? I would like to use new versions.
Updated•8 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•