407650 - Livemark service cleanup

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

* A bunch of trailing whitespace, entirely too much of which is mine

* Remove the unused and thus misleading |var gLivemarkService;|

* Remove the no longer true comment about getSiteURI being copied into toolbar.xml

* Take out the temporary logging for bug 381894, and turn the problem-hiding try{} catch{} into a check for the annotation before accessing it

* Move the misplaced comment I saw during bug 392984 but forgot to move

No new tests, since the only actual content, the getSiteURI part, is already tested four times by my count.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: -w

diff -up8w, for your "um, are there any actual changes here?" viewing pleasure.

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 292367 [details] [diff] [review]
Fix v.1

r=me, thanks sir.

Comment 3

[Phil Ringnalda (:philor)]

toolkit/components/places/src/nsLivemarkService.js 1.31

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv