Closed Bug 407656 Opened 12 years ago Closed 12 years ago

Canceling a scanning download should make it done

Categories

(Toolkit :: Downloads API, defect)

defect
Not set

Tracking

()

VERIFIED WONTFIX

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(1 file)

Instead of making a scanning download canceled when canceling, we should just let it finish as if there was no scan.

Bug 407655 introduces this into the UI, but there's potentially other calls to CancelDownload.
Blocks: 407657
Depends on: 407660
Attached patch v1Splinter Review
I actually haven't tested this.. I'll try getting a windows build.

Note for the UI, I changed it to delete only if the download is actually canceled by the back-end. Hopefully the SetState FINISHED notification gets to the UI to update "state" so that checking it works..
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #292471 - Flags: review?(comrade693+bmo)
<beltzner> well, I think we've pretty much decided that cancel sucks
<beltzner> I think we need to make sure to look for bad hanging cases, fix the restart case, and then see if we need to pref this off

WONTFIX

We'll need a bug to fix the case where we crash so we can set it right, and perhaps a bug to timeout if we don't get feedback from the virus scanner (since we can't find in the api where it says it times out.  Perhaps I was seeing things when I read that?).

Please file follow-up at least for the first issue.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Attachment #292471 - Flags: review?(comrade693+bmo)
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.