polish Delete Server Certificate Exceptions dialog

VERIFIED FIXED in mozilla1.9beta3

Status

Core Graveyard
Security: UI
VERIFIED FIXED
11 years ago
2 years ago

People

(Reporter: wladow, Assigned: wladow)

Tracking

({polish})

Trunk
mozilla1.9beta3
x86
Windows Vista
polish

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments, 1 obsolete attachment)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007121009 Minefield/3.0b2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007121009 Minefield/3.0b2pre

Delete Server Certificate Exceptions dialog should be polished. Server name string is misaligned and info string is too long (in locales (f.e. sk) is even longer), it should be wrapped.

Reproducible: Always

Steps to Reproduce:
1. Open Certificate Manager
2. click on Servers tab
3. select any Certificate Name
4. click on Delete button
(Assignee)

Updated

11 years ago
Version: unspecified → Trunk
(Assignee)

Comment 1

11 years ago
Created attachment 292468 [details]
Delete Server Certificate Exceptions dialog

Updated

11 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: polish
Created attachment 292634 [details] [diff] [review]
Style the strings to wrap, add width hint
[Checkin: Comment 6]

Just dashed it off, and picked the width hint mostly out of the air.  Is this all we need?
Assignee: kengert → johnath
Status: NEW → ASSIGNED
Attachment #292634 - Flags: review?(kengert)
Created attachment 292635 [details]
With patch, on mac

Comment 4

11 years ago
Comment on attachment 292634 [details] [diff] [review]
Style the strings to wrap, add width hint
[Checkin: Comment 6]

Looks good, thanks Johnathan!
Attachment #292634 - Flags: review?(kengert) → review+
Comment on attachment 292634 [details] [diff] [review]
Style the strings to wrap, add width hint
[Checkin: Comment 6]

Nom'ng for approval - Polish bug in PSM that is slightly more visible now that we're directing people to the cert manager to add/remove site exceptions.
Attachment #292634 - Flags: approval1.9?

Updated

11 years ago
Attachment #292634 - Flags: approval1.9? → approval1.9+
Checking in security/manager/pki/resources/content/deletecert.xul;
/cvsroot/mozilla/security/manager/pki/resources/content/deletecert.xul,v  <--  deletecert.xul
new revision: 1.17; previous revision: 1.16
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

11 years ago
Created attachment 293386 [details]
dialog with patch on Vista

Server name is still misaligned on Win Vista, see attachment.

Checked with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2007121605 Minefield/3.0b3pre
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2007121602 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

This caused 2
{{
Warning: Error in parsing value for property 'white-space'.  Declaration dropped.
Source File: chrome://pippki/content/deletecert.xul
Line: 0
}}
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: --- → mozilla1.9 M11
(Assignee)

Comment 9

11 years ago
Created attachment 296947 [details] [diff] [review]
fix server name misalignment

Here a simple low-risk patch to fix misalignment issue. Tested on WinVista with latest Firefox and SeaMonkey nightlies.
Attachment #296947 - Flags: review?(kengert)
Attachment #292634 - Attachment description: Style the strings to wrap, add width hint → Style the strings to wrap, add width hint [Checkin: Comment 6]
Comment on attachment 296947 [details] [diff] [review]
fix server name misalignment


>   <description id="confirm" style="white-space: wrap; width: 400px;"/>
>   <separator />
>-  <vbox id="certlist"/>
>+  <vbox id="certlist" class="box-padded"/>
>   <separator />
>   <description id="impact" style="white-space: wrap; width: 400px;"/>

Thanks for the updated patch! See comment 8 though - if we're going to land this, we should fix the error as well.  My original patch added white-space: wrap, but that's not a valid CSS identifier.  We should either change it to something that is ("-moz-pre-wrap", or "normal") or just remove it, since the width hint should really be enough.
(Assignee)

Updated

11 years ago
Attachment #296947 - Flags: review?(kengert)
Created attachment 296974 [details] [diff] [review]
fix server name misalignment v2 [checked in]

patch fixes server name misalignment and removes white-space per comment #10
Assignee: johnath → valastiak
Attachment #296947 - Attachment is obsolete: true
Status: REOPENED → ASSIGNED
Attachment #296974 - Flags: review?(kengert)

Comment 12

11 years ago
Comment on attachment 296974 [details] [diff] [review]
fix server name misalignment v2 [checked in]

I tested the patch on Linux, looks good to me. Thanks!

r=kengert
Attachment #296974 - Flags: review?(kengert) → review+
(Assignee)

Updated

11 years ago
Attachment #296974 - Flags: approval1.9?

Updated

11 years ago
Attachment #296974 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed

Comment 13

11 years ago
Comment on attachment 296974 [details] [diff] [review]
fix server name misalignment v2 [checked in]

I checked in this patch.

Checking in deletecert.xul;
/cvsroot/mozilla/security/manager/pki/resources/content/deletecert.xul,v  <--  deletecert.xul
new revision: 1.18; previous revision: 1.17
done
Attachment #296974 - Attachment description: fix server name misalignment v2 → fix server name misalignment v2 [checked in]

Comment 14

11 years ago
I guess this is fixed?
Please reopen if not.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008011501 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

V.Fixed (on Win2K) between these two nightlies,
both JS error(s) and text alignment.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008011602 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.