407800 - Port generic/automatic remoting changes to QNX Neutrino

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Max Feil - mfeil%qnx.com]

See bugzilla bug 280725. Changes were made to the xremote mechanism to move it out of the os-specific widget code and into the more generic command line code in the toolkit.

This bug implements the corresponding changes for the QNX Neutrino Mozilla based browser:
1) The xremote related code is remoted from widget/src/photon/.
2) The nsPhMozRemoteHelper.* source files remoted in step 1 are renamed to nsPhRemoteService.* and modified to work under toolkit/components/remote/.
3) Finally the photon specific code in widget/src/xremoteclient is modified so that the mozilla-xremote-client utility works as it did before.

These changes are all Neutrino-only and should not affect any other platform, and in theory cannot bust any Tinderbox builds.

Comment 1

[Max Feil - mfeil%qnx.com]

Attachment: Proposed Neutrino changes for xremote facility

Note that toolkit/components/remote/nsPhRemoteService.cpp and toolkit/components/remote/nsPhRemoteService.h appear as new in this patch, but they are really modifications of the removed widget/src/photon/nsPhMozRemoteHelper.cpp (under bug 280725) and the proposed to be removed widget/src/photon/nsPhMozRemoteHelper.h.

I am asking Benjamin Smedberg to review this because he made the changes for the original bug 280725. Also, he is aware of the situation where code changes under strictly photon-only source directories cannot cause any bustage because they are not part of Tinderbox builds.

Comment 2

[Max Feil - mfeil%qnx.com]

Comment on attachment 292476 [details] [diff] [review]
Proposed Neutrino changes for xremote facility

Landed on head. Now need approval for MOZILLA_1_8_BRANCH

Checking in toolkit/components/remote/Makefile.in;
/cvsroot/mozilla/toolkit/components/remote/Makefile.in,v  <--  Makefile.in
new revision: 1.12; previous revision: 1.11
done
RCS file: /cvsroot/mozilla/toolkit/components/remote/nsPhRemoteService.cpp,v
done
Checking in toolkit/components/remote/nsPhRemoteService.cpp;
/cvsroot/mozilla/toolkit/components/remote/nsPhRemoteService.cpp,v  <--  nsPhRem
oteService.cpp
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/components/remote/nsPhRemoteService.h,v
done
Checking in toolkit/components/remote/nsPhRemoteService.h;
/cvsroot/mozilla/toolkit/components/remote/nsPhRemoteService.h,v  <--  nsPhRemot
eService.h
initial revision: 1.1
done
Checking in widget/src/photon/Makefile.in;
/cvsroot/mozilla/widget/src/photon/Makefile.in,v  <--  Makefile.in
new revision: 1.53; previous revision: 1.52
done
Removing widget/src/photon/nsPhMozRemoteHelper.h;
/cvsroot/mozilla/widget/src/photon/nsPhMozRemoteHelper.h,v  <--  nsPhMozRemoteHe
lper.h
new revision: delete; previous revision: 1.4
done
Checking in widget/src/photon/nsWidgetFactory.cpp;
/cvsroot/mozilla/widget/src/photon/nsWidgetFactory.cpp,v  <--  nsWidgetFactory.c
pp
new revision: 1.42; previous revision: 1.41
done
Checking in widget/src/xremoteclient/PhRemoteClient.cpp;
/cvsroot/mozilla/widget/src/xremoteclient/PhRemoteClient.cpp,v  <--  PhRemoteCli
ent.cpp
new revision: 1.8; previous revision: 1.7
done
Checking in widget/src/xremoteclient/PhRemoteClient.h;
/cvsroot/mozilla/widget/src/xremoteclient/PhRemoteClient.h,v  <--  PhRemoteClien
t.h
new revision: 1.4; previous revision: 1.3

Comment 3

[Daniel Veditz [:dveditz]]

Comment on attachment 292476 [details] [diff] [review]
Proposed Neutrino changes for xremote facility

approved for 1.8.1.12, a=dveditz for release-drivers

Comment 4

[Max Feil - mfeil%qnx.com]

Checking in toolkit/components/remote/Makefile.in;
new revision: 1.6.8.1; previous revision: 1.6
Checking in toolkit/components/remote/nsPhRemoteService.cpp;
new revision: 1.1.2.1; previous revision: 1.1
Checking in toolkit/components/remote/nsPhRemoteService.h;
new revision: 1.1.2.1; previous revision: 1.1
Checking in widget/src/photon/Makefile.in;
new revision: 1.51.8.2; previous revision: 1.51.8.1
Removing widget/src/photon/nsPhMozRemoteHelper.h;
new revision: delete; previous revision: 1.3
Checking in widget/src/photon/nsWidgetFactory.cpp;
new revision: 1.41.28.1; previous revision: 1.41
Checking in widget/src/xremoteclient/PhRemoteClient.cpp;
new revision: 1.6.28.2; previous revision: 1.6.28.1
Checking in widget/src/xremoteclient/PhRemoteClient.h;
new revision: 1.2.28.2; previous revision: 1.2.28.1

Comment 5

[Al Billings [:abillings - ex-MoCo]]

Is there any verification necessary here from QA? It doesn't look like it. If not, can Max verify that the change was committed and change the keyword from "fixed1.8.12" to "verified1.8.12"?