[valgrind] conditional depends on uninitialized data in nsUrlClassifierDBServiceWorker

RESOLVED FIXED

Status

()

Toolkit
Safe Browsing
RESOLVED FIXED
11 years ago
4 years ago

People

(Reporter: Robert Sayre, Assigned: dcamp)

Tracking

({valgrind})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

fix
907 bytes, patch
Tony Chang (Google)
: review+
damons
: approval1.9+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
Probably just need to initialize some members.

==29183== Conditional jump or move depends on uninitialised value(s)
==29183==    at 0x672C9BF: nsUrlClassifierDBServiceWorker::FlushChunkLists() (nsUrlClassifierDBService.cpp:1512)

==29183== Conditional jump or move depends on uninitialised value(s)
==29183==    at 0x672C9E5: nsUrlClassifierDBServiceWorker::FlushChunkLists() (nsUrlClassifierDBService.cpp:1516)
(Reporter)

Updated

11 years ago
Summary: uninitialized data in nsUrlClassifierDBServiceWorker → [valgrind] conditional depends on uninitialized data in nsUrlClassifierDBServiceWorker
(Assignee)

Comment 1

11 years ago
Created attachment 292622 [details] [diff] [review]
fix
Assignee: nobody → dcamp
Status: NEW → ASSIGNED
Attachment #292622 - Flags: review?(tony)

Comment 2

11 years ago
Comment on attachment 292622 [details] [diff] [review]
fix

Yes.
Attachment #292622 - Flags: review?(tony) → review+
(Assignee)

Updated

11 years ago
Attachment #292622 - Flags: approval1.9?

Updated

11 years ago
Attachment #292622 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 3

11 years ago
Checking in src/nsUrlClassifierDBService.cpp;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp,v  <--  nsUrlClassifierDBService.cpp
new revision: 1.45; previous revision: 1.44
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Keywords: valgrind
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.