Closed Bug 407921 Opened 17 years ago Closed 17 years ago

Metrics: Link Errors on win32

Categories

(Toolkit Graveyard :: Data Collection/Metrics, defect)

Product:
Toolkit Graveyard
Component:
Data Collection/Metrics
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: pete, Assigned: pete)

Details

Attachments

(2 files, 1 obsolete file)

proposed patch
416 bytes, patch
janv
: review+
Details | Diff | Splinter Review
updated again
487 bytes, patch
janv
: review+
Details | Diff | Splinter Review 
Linking fails on win32.

Patch forthcoming.
Attached patch proposed patch — — Splinter Review 
Jan, is rolling a verify build on win32.
Jan can you review patch after you have finished our verification build?
Status: NEW → ASSIGNED
yeah, my build failed on windows too
I found this:
http://lxr.mozilla.org/seamonkey/source/extensions/metrics/src/Makefile.in#110

Do we need to add NODEFAULTLIB:MSVCRTD too ?

Hrm, adding it to the build/ Makefile seemed to fix the issue for me. Did it work for you?
Comment on attachment 292608 [details] [diff] [review]
proposed patch

Yeah, this patch fixes the problem.
Attachment #292608 - Flags: review+
patch checked in ...
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Wait, Jan I think LDFLAGS should be wrapped w/ 

ifeq ($(OS_ARCH),WINNT)
  LDFLAGS += -NODEFAULTLIB:MSVCRT
endif
Attached patch updated patch (obsolete) — — Splinter Review 

    
    

    
  
Jan can you review if it looks good to you?

    
    

    
  

      
      
      
      

        Attached patch
          
          
        updated again
        — 
          — Splinter Review
      

    


  

        Attachment #292615 -
        Attachment is obsolete: true

    
  

        Attachment #292619 -
        Flags: review+

    
    

    
  
Pete, it seems you checked in wrong patch. I don't see GNU_CC there.


    
  
Product: Toolkit → Toolkit Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: