407984 - get rid of the scrollboxes in autocomplete.xml

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[(not reading, please use [e-mail] instead)]

perf:  get rid of the scrollboxes / ellipsis hack in autocomplete.xml

Until we have bug #312156 (implement text-overflow: ellipsis from CSS3 text), I
was planning to do what we currently do, which is to have the description
inside a scrollbox, followed by a label.  the value of the label is either the
localized ellipsis character or "", depending on if the description element is
bigger than the scrollbox, see _setUpEllipsis()

http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/autocomplete.xml#1266

Once we had #312156, or if we had another way of making crop attribute work
with description even I don't use the value attribute (see bug #404427), I
could remove all those scrollboxes (two per autocomplete item, so 50 in total
by default), the additional labels for the ellipsis, and the hacky code to
hide/show the ellipsis (which gets called on setTimeout.)

Comment 1

[(not reading, please use [e-mail] instead)]

a trick that vlad came up with last week to get rid of the scrollbox:

<hbox>
<hbox style="overflow-x: hidden;">
<description width="200">aasadfadfasdfasdfadsfadfasdfsssssssa<html:span>test</html:span>bbb</description>
</hbox>
<label id="ellipsis"/>
</hbox>

Note, I'm using span instead of label, we're moving to span for RTL issues.

using crop="right" on the description will not work, which is bug #404427

(Excuse the shorthand for the ellipsis.)

Comment 2

[(not reading, please use [e-mail] instead)]

note, I can't get rid of the ellipsis hack (yet), but I was able to get rid of the scrollboxes, thanks to vlad's suggestion from last week.

I'll attach a patch here, but I think this will be part of an bigger patch to use span to address rtl issues with <label> (instead of span).

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: work in progress patch

Comment 4

[(not reading, please use [e-mail] instead)]

morphing this bug to cover the scrollboxes.

in bug #407944 vlad writes:

"Note that you really, really, really want to get rid of the scrollboxes for the
final, regardless if things get implemented using selection or something else. 
They cause a native OS widget to be created per scrollbox."

I've got bug #405918 to cover the ellipsis hackery.

Comment 5

[(not reading, please use [e-mail] instead)]

fixed as part of bug #402118

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED via Bonsai:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=autocomplete.xml&branch=&root=/cvsroot&subdir=mozilla/toolkit/content/widgets&command=DIFF_FRAMESET&rev1=1.99&rev2=1.100

There's still a comment about "scrollbox" (see http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/toolkit/content/widgets&command=DIFF_FRAMESET&file=autocomplete.xml&rev2=1.93&rev1=1.92), but I don't know if that should've been/should be removed or not.