408021 - Hover feedback for tab close button

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Michael Ventnor]

Attachment: Patch

I've figured out a way to fix this problem. Its not pretty, but its the only way I know of. And believe me, I've tried a lot of things.

This will give the tab close button hover feedback while still keeping the tabs at a reasonable size, and without causing glitches.

Comment 1

[Ian Spence]

It would be nice if this could be expanded to fix the findbar close button and the sidebar close buttons, perhaps even a .close-button class so that addons like Firebug could have nice looking close buttons for their panels

Comment 2

[Michael Ventnor]

Attachment: Patch 2

This expands the patch to fix the currently-distorted sidebar close button.

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 292717 [details] [diff] [review]
Patch 2

Oh, it's not that evil ;)

>Index: browser/themes/gnomestripe/browser/browser.css
> .tab-close-button {
>-  -moz-appearance: none;
>+  -moz-appearance: toolbarbutton;
Uber nit: you can just drop the -moz-appearance altogether.

Comment 4

[Ryan Flint [:rflint] (ping via IRC for reviews)]

I didn't check, but you might also need to set an outline: none on tabs-closebutton's image when it's focused to avoid ending up with two focus rings when it's clicked.

Comment 5

[Michael Ventnor]

Attachment: Nit fix

Comment 6

[Michael Ventnor]

(In reply to comment #4)
> I didn't check, but you might also need to set an outline: none on
> tabs-closebutton's image when it's focused to avoid ending up with two focus
> rings when it's clicked.
> 

I tried that before but it had no effect. Either way the button only has one focus ring.

Comment 7

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.147; previous revision: 1.146
done