408024 - when setting the width of the boxes that hold the description elements, use Math.floor()

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[(not reading, please use [e-mail] instead)]

when setting the width of the boxes that hold the description elements, use Math.floor() 

a suggestion from vlad.

included in the patch for bug #402118

Comment 1

[Jesse Ruderman]

I'm curious why this is a perf improvement.

Comment 2

[(not reading, please use [e-mail] instead)]

When working with vlad, he noticed that the current code was setting widths to values like 526.22 px (instead of 526), and figured it would be better (for layout) to set the minWidth / maxWidth of the scrollboxes (now hboxes) that contain the <description>...<html:span>...</html:span>...</description> content

Note, we only end up calling Floor() the first time the richlistitems are created, and again (once per richlistitem) if you resize the window.

I'll go isolate just this change and see if I can actually measure the perf gain.

Comment 3

[(not reading, please use [e-mail] instead)]

after isolating the Math.floor() change and using https://bugzilla.mozilla.org/attachment.cgi?id=292723 to test, I'm not seeing anything I can consistently measure either way, so I've removed the perf keyword.

Comment 4

[(not reading, please use [e-mail] instead)]

fixed as part of bug #402118