408119 - Firefox should clear gtk icon cache on theme change

Status: NEW

Description

[Ian Spence]

When you change your gtk theme, Firefox updates its display accordingly. However, if you change your icon theme, it does not update the display, although any native icons that had not been previously viewed (likely cause it's only used in some dialog you rarely see), will load from the new icon theme.

Steps to reproduce:
1. Start a new session of Firefox.
2. Navigate to a single page (to enable the back button)
3. Change the icon theme via the gnome panel.
4. Press the back button.

Expected Results:
Step 3 should result in every icon that we receive from gtk being reloaded from the new theme.

Actual Results:
You now have a back button from your original theme and a forward button from the newly selected theme. Furthermore, your disabled forward button is a different icon theme than your non-disabled forward button.


I believe the fix should be as simple as removing any cached moz-icon://stock/* images before forcing the repaint. I believe the icon-theme change signal just piggybacks on the main theme change signal, so it'd probably be best just to put the code in the same function that handles the normal theme change.

I'll attach a screenshot in a second.

Comment 1

[Ian Spence]

Created attachment 292867 [details]
My toolbar showing the problem

This shows the result of the steps described if I start with the gnome icon theme and change to the human icon theme