408214 - crash reporter sending random "Name" field

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[(not currently active) Ted Mielczarek]

Regression from bug 396209, we're sending a random empty "Name" field with the params.  Looks like it's happening here:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/crashreporter/client/crashreporter_win.cpp&rev=1.19#833

Is that supposed to be "ProductName"?  Must have missed that in my review.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch

Um, oops!

I'm out of town at the moment, but this seems like a trivial fix. Haven't tested it though.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 293159 [details] [diff] [review]
Patch

Yeah, that's what I thought.  That's the only reference to "Name", so I think that's it.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 293159 [details] [diff] [review]
Patch

Trivial typo fix that allows us to distinguish between products in the Crash Reporter.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Fixed on trunk.