408287 - Strict warnings in calendar-task-tree.xml on double click and startup

Status: VERIFIED FIXED

Description

[Martin Schröder [:martinschroeder]]

Warning: reference to undefined property col.value.anonid
Source File: chrome://calendar/content/calendar-task-tree.xml
Line: 436

Comment 1

[Stefan Sitter]

The following warning in calendar-task-tree.xml is shown during startup:

Warning: function tTV_modifyItem does not always return a value
Source File: chrome://calendar/content/calendar-task-tree.xml
Line: 244, Column: 10
Source Code:
          },

The warning from Comment #0 is now:

Warning: reference to undefined property col.value.anonid
Source File: chrome://calendar/content/calendar-task-tree.xml
Line: 457

Comment 2

[gekacheka]

Created attachment 295647 [details] [diff] [review]
v1 patch: eliminate return val, use col.element.getAttribute

(patch -l -p 1 -i file.patch)

modifyItem should not be returning a value.
onDoubleClick should use col.element.getAttribute.

Also clarified onDoubleClick to create a new to-do on double clicks in the checkbox column if in an empty row.  (If not on an empty row and in checkbox column, then the first click will always modify it.  In my quick attempts I wasn't able to get it to open a dialog with the unmodified state.)

Comment 3

[Michael Büttner (no reviews TFN)]

Comment on attachment 295647 [details] [diff] [review]
v1 patch: eliminate return val, use col.element.getAttribute

Thanks for taking care. r=mickey.

Comment 4

[Michael Büttner (no reviews TFN)]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 5

[Martin Schröder [:martinschroeder]]

VERIFIED
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12pre) Gecko/20080204 Thunderbird/2.0.0.12pre Lightning/0.8pre (2008020318)