If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Strict warnings in calendar-task-tree.xml on double click and startup

VERIFIED FIXED in 0.8

Status

Calendar
Tasks
--
trivial
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: martinschroeder, Assigned: gekacheka)

Tracking

unspecified

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Warning: reference to undefined property col.value.anonid
Source File: chrome://calendar/content/calendar-task-tree.xml
Line: 436

Comment 1

10 years ago
The following warning in calendar-task-tree.xml is shown during startup:

Warning: function tTV_modifyItem does not always return a value
Source File: chrome://calendar/content/calendar-task-tree.xml
Line: 244, Column: 10
Source Code:
          },

The warning from Comment #0 is now:

Warning: reference to undefined property col.value.anonid
Source File: chrome://calendar/content/calendar-task-tree.xml
Line: 457
Summary: Warning on double click in Task view → Strict warnings in calendar-task-tree.xml on double click and startup
(Assignee)

Comment 2

10 years ago
Created attachment 295647 [details] [diff] [review]
v1 patch: eliminate return val, use col.element.getAttribute

(patch -l -p 1 -i file.patch)

modifyItem should not be returning a value.
onDoubleClick should use col.element.getAttribute.

Also clarified onDoubleClick to create a new to-do on double clicks in the checkbox column if in an empty row.  (If not on an empty row and in checkbox column, then the first click will always modify it.  In my quick attempts I wasn't able to get it to open a dialog with the unmodified state.)
Attachment #295647 - Flags: review?(michael.buettner)
(Reporter)

Updated

10 years ago
Assignee: nobody → gekacheka
(Reporter)

Updated

10 years ago
Status: NEW → ASSIGNED
Comment on attachment 295647 [details] [diff] [review]
v1 patch: eliminate return val, use col.element.getAttribute

Thanks for taking care. r=mickey.
Attachment #295647 - Flags: review?(michael.buettner) → review+
patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Reporter)

Updated

10 years ago
Target Milestone: --- → 0.8
(Reporter)

Comment 5

10 years ago
VERIFIED
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12pre) Gecko/20080204 Thunderbird/2.0.0.12pre Lightning/0.8pre (2008020318)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.