Closed
Bug 408287
Opened 18 years ago
Closed 17 years ago
Strict warnings in calendar-task-tree.xml on double click and startup
Categories
(Calendar :: Tasks, defect)
Calendar
Tasks
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: mschroeder, Assigned: gekacheka)
Details
Attachments
(1 file)
2.09 KB,
patch
|
michael.buettner
:
review+
|
Details | Diff | Splinter Review |
Warning: reference to undefined property col.value.anonid
Source File: chrome://calendar/content/calendar-task-tree.xml
Line: 436
Comment 1•18 years ago
|
||
The following warning in calendar-task-tree.xml is shown during startup:
Warning: function tTV_modifyItem does not always return a value
Source File: chrome://calendar/content/calendar-task-tree.xml
Line: 244, Column: 10
Source Code:
},
The warning from Comment #0 is now:
Warning: reference to undefined property col.value.anonid
Source File: chrome://calendar/content/calendar-task-tree.xml
Line: 457
Summary: Warning on double click in Task view → Strict warnings in calendar-task-tree.xml on double click and startup
(patch -l -p 1 -i file.patch)
modifyItem should not be returning a value.
onDoubleClick should use col.element.getAttribute.
Also clarified onDoubleClick to create a new to-do on double clicks in the checkbox column if in an empty row. (If not on an empty row and in checkbox column, then the first click will always modify it. In my quick attempts I wasn't able to get it to open a dialog with the unmodified state.)
Attachment #295647 -
Flags: review?(michael.buettner)
Reporter | ||
Updated•17 years ago
|
Assignee: nobody → gekacheka
Reporter | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Comment 3•17 years ago
|
||
Comment on attachment 295647 [details] [diff] [review]
v1 patch: eliminate return val, use col.element.getAttribute
Thanks for taking care. r=mickey.
Attachment #295647 -
Flags: review?(michael.buettner) → review+
Comment 4•17 years ago
|
||
patch checked in on trunk and MOZILLA_1_8_BRANCH
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•17 years ago
|
Target Milestone: --- → 0.8
Reporter | ||
Comment 5•17 years ago
|
||
VERIFIED
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12pre) Gecko/20080204 Thunderbird/2.0.0.12pre Lightning/0.8pre (2008020318)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•