408294 - [proto] area around tab borders lacks transparency

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: screenshot showing problem

In Proto, tab borders get drawn by images like tab-left.png, and these images contain both the tab borders themselves and a little bit of the area around the borders.  But the area around the borders in the images is non-transparent, even though it is the same color as the underlying tab container that surrounds the tabs.

This is not just unnecessary, it makes it hard for extensions (and themes, when Proto becomes the default theme) like Personas to simply change the background of the tab container, since the area around the borders retains the default background color.

See the attached screenshot for an example of the problem.  In it, the Personas extension has changed the background of the tab container, but the area around the tabs retains its default background.

That area should be transparent so that extension and themes can easily modify the tab container background.

(Related but probably different issue: the border at the bottom of the tab container gets drawn by the images as well, so extensions that modify the tab container background remove the border in areas of the container that don't have tabs but don't remove it from areas that do have tabs.  That border should be drawn by CSS so that it can be modified independently.)

Comment 1

[Florian Quèze [:florian]]

This is also visible while dragging a tab.

Comment 2

[Asa Dotzler [:asa]]

same as bug 418484? 

Comment 3

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #2)
> same as bug 418484? 

Yeah, I think that bug is caused by the same problem.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Kevin, are there vector originals of these images?  If so, we could use those to recreate the PNGs with tab borders that antialias to transparency rather than to the default background color.  Otherwise, I suppose it might be possible to perform this transformation on the PNGs themselves, although I'm not sure how.

Requesting blocking-firefox3 for the issue that the area shows up while dragging a tab, wanted-firefox3 for the issue that it's more difficult to theme the app.

Comment 6

[Kevin Gerich]

Yes, I've requested the source images from Stephen and will make the transparent images when I get them.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #6)
> Yes, I've requested the source images from Stephen and will make the
> transparent images when I get them.

Thanks Kevin!  Note also bug 420220, which might be most easily fixed in conjunction with the fix for this bug.

Comment 9

[Mike Connor [:mconnor]]

Fixed on trunk by new theme landings.