408295 - avoid temporary arrays when cascading style rules

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: use RuleValue's linked list instead of arrays while cascading

Sicking was bugging my about allocations growing the temporary per-weight arrays we use when doing CSS cascading.  This avoids those allocations by using an existing linked-list pointer to store those lists.

This patch does so; it applies on top of the patch in bug 408135.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Oh, and AddRule doesn't need to be PR_STATIC_CALLBACK anymore, just static.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: use RuleValue's linked list instead of arrays while cascading

Fix that, and a few comments.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 293048 [details] [diff] [review]
use RuleValue's linked list instead of arrays while cascading

Sweet!

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is pretty low risk in the sense that if it broke anything, it would massively break the Firefox UI, and we'd notice.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk.