408350 - Enter/return on downloads should do the same as double click

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

Right now pressing enter does nothing... Can probably reuse some logic of double click.. except double click takes an event and enter would need to look up the currently selected item.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

How convenient that there's a function to call! ;) ;)

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 293346 [details] [diff] [review]
v1

r=sdwilsh

Comment 3

[Ed Lee :Mardak]

Checking in toolkit/mozapps/downloads/content/downloads.xul;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.xul,v  <--  downloads.xul
new revision: 1.41; previous revision: 1.40
done

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2007121802
Minefield/3.0b3pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre)
Gecko/2007121801 Minefield/3.0b3pre

and Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2007121802
Minefield/3.0b3pre

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

I have amended the following testcases to include double-clicking as well as Enter/Return (to cover bug 408351).

Active downloads: https://litmus.mozilla.org/show_test.cgi?id=4552
Paused downloads: https://litmus.mozilla.org/show_test.cgi?id=4577
Cancelled/failed downloads: https://litmus.mozilla.org/show_test.cgi?id=4580
Completed downloads: https://litmus.mozilla.org/show_test.cgi?id=3976

in-litmus+