408351 - Double click download should do default action (first item in menu)

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

After bug 407655 lands, the first item is the default action, so instead of redefining the default actions for each state in the double click code, we can just use the first item's command.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Move the logic into a separate function for doing the default for selected item. Note that the double click handler is only for the gDownloadsView which only contains richlistitem downloads.

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 293345 [details] [diff] [review]
v1

r=sdwilsh

Comment 3

[Ed Lee :Mardak]

Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v  <--  downloads.js
new revision: 1.118; previous revision: 1.117
done

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified; tested with failed, paused, and of course completed download types on:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2007121802 Minefield/3.0b3pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2007121801 Minefield/3.0b3pre

and Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2007121802 Minefield/3.0b3pre

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

I have amended the following testcases to include double-clicking as well as Enter/Return (to cover bug 408350).

Active downloads: https://litmus.mozilla.org/show_test.cgi?id=4552
Paused downloads: https://litmus.mozilla.org/show_test.cgi?id=4577
Cancelled/failed downloads: https://litmus.mozilla.org/show_test.cgi?id=4580
Completed downloads: https://litmus.mozilla.org/show_test.cgi?id=3976

in-litmus+