408354 - The Page Info View Certificates label has the "v" character underlined as an access key

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect)

Description

[(no longer active)]

Attachment: Screenshot

Please see the attached screenshot.  Since the View Certificates is a button with an access key, the access key on the label is redundant.  This is caused because a XUL <label> control is used for this label, which obtains the access key from its "control" attribute, if provided.  I'll be posting a patch shortly.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Trivial patch to switch the <label> control with a <description> control.

Comment 2

[Asaf Romano (gone)]

This seems wrong... what's the purpose of setting the control attribute there anyway? should we just use labelledby?

Comment 3

[Aaron Leventhal]

FWIW, the a11y module makes use of <description control="[id]"> where a description is associated with a specific control or container (groupbox etc.)

Descriptions are secondary information associated with a control or a container that are important to understanding it. Most static text in a dialog should be either a label or a description.

Comment 4

[Aaron Leventhal]

For this bug, I'm not sure what this text gets set to, but here's an example of a description for a button in Firefox:

Tools -> Options -> Main ->

--  Add-ons ---------------------------------------------------------

Change options for your add-ons               [_M_anage add-ons]

---------------------------------------------------------------------


The description for the button is "Change options for your add-ons". By associating it with the button it means that text will be read when the button gets focused.

Comment 5

[(no longer active)]

Comment on attachment 293120 [details] [diff] [review]
Patch (v1)

Here is what the static text and button look like:

This web site provides a certificate to verify its identity   [_V_iew Certificate]

I'm asking for Aaron's review on whether he thinks a <description control=...> is appropriate for this control.  I think it is, based on Aaron's comments.  I'm ask for Mano's review once again if Aaron's review is positive.

Comment 6

[Asaf Romano (gone)]

Aaron: is it by design that accesskeys are set for labels but not for descriptions when the control attribute is used? Is the control attribute still honored at all in this case?

Comment 7

[Aaron Leventhal]

Comment on attachment 293120 [details] [diff] [review]
Patch (v1)

Yes, that's exactly what <description control> is for.

Comment 8

[Aaron Leventhal]

Mano, yes that's by design. The control attribute for description only affects screen reader usage -- it makes the description get spoken when the control gets focused. Exact behavior on when it's spoken depends on the particular screen reader and the user's verbosity settings.

Comment 9

[(no longer active)]

Comment on attachment 293120 [details] [diff] [review]
Patch (v1)

Requesting code review again based on Aaron's r+...

Comment 10

[Asaf Romano (gone)]

Comment on attachment 293120 [details] [diff] [review]
Patch (v1)

r=mano, thanks.

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 293120 [details] [diff] [review]
Patch (v1)

a=mconnor on behalf of drivers

Comment 12

[Asaf Romano (gone)]

mozilla/browser/base/content/pageinfo/pageInfo.xul 1.13