408357 - Error when the invite command is used in Private Chat.

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Mitchell Field [:Mitch]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: ChatZilla 0.9.79-2007121222

When in a private chat, using /invite with any single parameter causes an error, instead of giving a friendly warning.

Reproducible: Always

Steps to Reproduce:
1. Open a private chat
2. Use /invite with exactly one parameter.
Actual Results:  
[ERROR]	Internal error dispatching command “invite”.
[ERROR]	TypeError: channel has no properties @ <chrome://chatzilla/content/commands.js> 3119

Expected Results:  
A friendly warning should have been given, stating that the command cannot be used within that context.

Comment 1

[:Gijs (he/him)]

Attachment: Patch

I'll recommend myself for suggestions on naming that string without having to re-align all those = signs while becoming a bit more informative. Other than that, r? -> Silver

Comment 2

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/locales/en-US/chrome/chatzilla.properties;
/cvsroot/mozilla/extensions/irc/locales/en-US/chrome/chatzilla.properties,v  <--  chatzilla.properties
new revision: 1.148; previous revision: 1.147
done
Checking in mozilla/extensions/irc/xul/content/commands.js;
/cvsroot/mozilla/extensions/irc/xul/content/commands.js,v  <--  commands.js
new revision: 1.137; previous revision: 1.136
done