408421 - Firefox Bookmark toolbar items overwritten by IE6 items on migration

Status: RESOLVED INCOMPLETE

(Firefox :: Migration, defect, P4)

Description

[u279076]

Firefox 3 Beta 2 RC1 - Win XP SP2 - build ID 2007121120

When I choose to migrate IE6 bookmarks using the first-run migration wizard, it overwrites everything on the Firefox bookmarks toolbar except for the "Smart Bookmarks" folder.

Using the File>Import method does not import the favourites from IE6's toolbar, thus, not overwriting the Firefox Bookmarks toolbar.

Steps to Reproduce:
1. Install Firefox
2. Start Firefox and close it (notice the bookmark items on the toolbar)
3. Open IE6 and save some favourites
4. Close IE6
5. Go to C:\Documents and Settings\<username>\Application Data and delete the Mozilla folder
6. Start Firefox again and choose to Import Internet Explorer Settings (you can import everything, but only bookmarks are needed)

Actual Results:
When Firefox loads, the bookmarks toolbar will be overwritten

Expected Results:
Any items on the IE6 bookmarks toolbar should be appended to the Firefox one (or maybe have an IE6 Bookmarks folder appear on the Firefox toolbar).

Alternatively, with a new Firefox profile, if you go to File>Import and select Internet Explorer settings this way, the favourites toolbar from IE6 does not get imported.

I will provide a screenshot of the before and after.

Comment 1

[u279076]

Attachment: SCREENSHOT: Bookmarks toolbar

Comment 2

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2007121500 Minefield/3.0b3pre

I get only a terrible hang that I killed after 8 minutes. When I open Firefox I see indeed no default set on the BT (but only some random bookmarks picked out of a random sub folder).  

Comment 3

[Ria Klaassen (not reading all bugmail)]

I tested some builds and it has no connection with the hang. The hang was earlier. It regressed between 2007112600 and 2007112701.

Comment 4

[Ria Klaassen (not reading all bugmail)]

Tested it for the presence of the default set after killing firefox.exe.

Comment 5

[Mike Connor [:mconnor]]

Isn't this how Fx2 behaved?  I'm not sure the behaviour's altogether wrong, and I think this is a dupe...

Comment 6

[u279076]

You are correct that FF2 behaves this way, but I disagree with your statement "I'm not sure the behaviour's altogether wrong".  Just because this is the way FF2 is doing something one way, doesn't mean it should not be reconsidered in FF3.  IMO, the bookmarks from IE should be appended on the toolbar, not overwriting the Firefox bookmarks.  What do you think?

As far as your "dupe" comment, I seem to recall there being a bug about this a couple months back.  If I recall correctly, it was IE7 related, not IE6 related.  I could be wrong on this one.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

I thought we fixed this in bug 386678. Bug 387137 and bug 261016 were duped to it.

Comment 8

[Ria Klaassen (not reading all bugmail)]

People who run the import wizard to import IE Favourites can't be else than new users. And the default set of bookmarks is meant for new users, to give some info about the Firefox browser.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Blocking, since unintended regressions should be looked into.

Comment 10

[Mike Connor [:mconnor]]

Not blocking on this bug for final ship. Would take a safe enough patch if one comes through.

Comment 11

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

intended behavior is:
- on initial migration of a new profile: import default bookmarks, add smart bookmarks, import other browser bookmarks.
- on migrations from the Library: import other browser bookmarks in a "From <browser>" folder.
Anything else is wontfix, the bug is unclear about what's the issue, and lacking recent steps to reproduce. As a side note, default bookmarks import is temporarily broken in FF14, though we'll fix that before release.