Closed Bug 408422 Opened 13 years ago Closed 12 years ago

sqlite is huge at -O3

Categories

(Toolkit :: Storage, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: sayrer, Unassigned)

References

Details

Bug 407794 made the optimization settings in the sqlite makefile actually take effect on mac and linux. There seems to be a tiny Ts win on mac and linux, but it doesn't show up on Talos.
Blocks: 407794
Component: SQL → Storage
Product: Core → Toolkit
QA Contact: irixman+bugzilla → storage
Version: unspecified → Trunk
Version: Trunk → unspecified
Version: unspecified → Trunk
So are we saying we don't want it to be huge and would rather take the perf hit, or what?
We don't know that -O3 is a perf win. We do know that it is larger.
So, a little more research shows that it is ~200k bigger at -O3 than -O2, and none of our metrics show a perf hit at -O2. The Ts win looks like it was from building spidermonkey at -Os, one of the other simultaneous changes we made.
drh tells me that we get a small win by compiling with -O3, but there's a small perf loss and a much smaller binary size with -Os.  We might want to look into making that switch.
We seem to be building with -O2 anyway, so this looks like it's WORKSFORME
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.