40855 - comment interpreted as <br> when inside <table><center>

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[Christos Cheretakis]

at bottom of page, there's a "page was updated <date>" entry. in the source
there's a comment between the text and the date. mozilla renders as if there was
a <br>.
linux-2000052520

Comment 1

[Christos Cheretakis]

Attachment: testcase

Comment 2

[Andreas Franke (gone)]

Attachment: minimal testcase with missing <TR><TD>, causing line break

Comment 3

[Andreas Franke (gone)]

Attachment: same testcase with added <TR><TD>, displays on one line

Comment 4

[Jeremy M. Dolan]

Christos' testcase is simply the full page...thats what the URL field is for
Christos.

Problem appears to be with text inside a <center> block thats inside a <table>,
which doesn't seem like it would be valid HTML. Sun's pages are absolutly
DISGUSTING, it's filled with this kind of cruft.

Attaching minimal test case.

Comment 5

[Jeremy M. Dolan]

Attachment: more minimal

Comment 6

[Jeremy M. Dolan]

Arg, collitions... gotta start using makingtest. My testcase is more minimal,
anyhow.

Comment 7

[Andreas Franke (gone)]

Yes, I got a collision, too. Will start using `makingtest', too.
The only thing left from my collision-comment is that 4.x displays
all testcases as expected on one line.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase with colors

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The above testcase makes this look much more like a Parser problem (although I
don't have access to viewer now, so I can't tell for sure).  Changing to Parser.

Comment 10

[harishd]

Over to my list for triage.

Comment 11

[harishd]

The layout does look bad...but..the bug as such is not a high priority. In other 
words it's not a beta blocker.  Moving to M18.

Comment 12

[Christos Cheretakis]

Works fine in linux/2000052920 in all pages at javasoft I checked

Comment 13

[Christos Cheretakis]

see it again as of 2000060908 on linux, there are some pages @ Sun however that
now do it with <p align="center"> instead of <center> and there it works fine.

Comment 14

[rickg]

Egads. This is due to SaveTokens(). The <center>, text, and comment are inside a 
<table> (malformed). They're supposed to get pushed out, but for some reason the 
<center> is closed when the comment appears. Ick, ick, ick. Bad Harish.

Comment 15

[harishd]

That's because comments, any where insided a table, are treated as legal. And 
why shouldn't it be?????? Anyway, the fix would be trivial.

I think you would see the same effect if there was a CAPTION inside 
CENTER instead of the comment. 

Comment 16

[harishd]

Recommended for nsbeta3.  Comments should not be the culprit in handling illegal 
table contents.

Comment 17

[harishd]

This bug has been marked "future" because the original netscape engineer working 
on this is over-burdened. If you feel this is an error, that you or another
known resource will be working on this bug,or if it blocks your work in some way 
-- please attach your concern to the bug for reconsideration. 

Comment 18

[Nisheeth Ranjan]

Marking nsbeta3-

Comment 19

[rickg]

I think we should reconsider this. When bogus content is found in a <table> 
before <tr>, it gets pushed out like nav did it. For some reason, text and 
comments aren't getting moved. This could lead to pretty bad (and 
non-compatible) behavior.

Comment 20

[harishd]

*** Bug 52012 has been marked as a duplicate of this bug. ***

Comment 21

[Jesse Ruderman]

All/all.  I can reproduce this on Windows 98, 2000093008.

Should this get a release note?

Comment 22

[ekrock's old account (dead)]

Nom. nsbeta1. We should handle HTML comments correctly. ;->

Comment 23

[harishd]

The bug seems to have gone away! Jan, could you please verify this. Thanx.

Marking WFM.

Comment 24

[Jan Carpenter]

Still broken on MTEST builds:
2001-01-31-14-MTEST : Win2K
2001-01-30-21-MTEST : Mac

but working fine on trunk builds:
2001-02-02-10-Mtrunk : Win98
2001-02-02-10-Mtrunk : Linux
2001-02-02-09-Mtrunk : Mac

Comment 25

[harishd]

What's an MTEST build?

Comment 26

[Christos Cheretakis]

wfm2, on both linux/2001020306 & win/2001020308

Comment 27

[harishd]

Fix is in. Marking FIXED.

Comment 28

[bsharma]

updated qa contact.

Comment 29

[bsharma]

Verified on
build: 2001-06-20-04-Trunk
platform: Win NT

The above test case and the test case with id 9299 loads fine.