408585 - installer doesn't display localized string 'components' correctly

Status: NEW

(SeaMonkey :: Installer, defect)

Description

[Vlado Valastiak [:wladow]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9b3pre) Gecko/2007121505 Minefield/3.0b3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9b3pre) Gecko/2007121505 Minefield/3.0b3pre

When displaying installer's Choose Optional Components page localized title string ending with char "í" is not displayed correctly. There is a blank space before this character -> word "súčastí" is then displayed like "súčast í". See attachment.

This affects at least 2 locales (sk, cs) and all products using installer in both branches. I see this in latest Minefield builds, Firefox 2 builds and SeaMonkeys builds (Thunderbird and Sunbird don't have this page). It affects both Vista and XP.

It is string OPTIONAL_COMPONENTS_TITLE in custom.properties file and it is typed correctly in l10n files, see http://lxr.mozilla.org/l10n/source/sk/browser/installer/custom.properties#54 for sk locale and http://lxr.mozilla.org/l10n/source/cs/browser/installer/custom.properties#54 for cs locale.


Reproducible: Always

Comment 1

[Vlado Valastiak [:wladow]]

Attachment: affected locales using Vista and XP

Comment 2

[Robert Strong (they/them - no direct email)]

Can you check if this is still the case with a nightly build now that bug 305039 is fixed? Thanks

Comment 3

[Vlado Valastiak [:wladow]]

Currently the only(?) app with optional components page enabled is SeaMonkey and I see this issue in its installer as well. Tested with Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9.1b3pre) Gecko/20090114 SeaMonkey/2.0a3pre

Comment 4

[Robert Strong (they/them - no direct email)]

Moving over to SeaMonkey's installer component.

Comment 5

[Vlado Valastiak [:wladow]]

Isn't it a core bug?

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: another screenshot

This shows that the problem only affects the title and not the sub-title in the wizard

Comment 7

[Robert Strong (they/them - no direct email)]

(In reply to comment #5)
> Isn't it a core bug?
If it is a core bug with NSIS then it will likely need to be fixed in NSIS itself. The toolkit -> NSIS Installer component is for the general NSIS scripts used by all of the apps and the App -> Installer components are for the specific scripts used by the apps which is where the code to set this text lives.

Comment 8

[Robert Strong (they/them - no direct email)]

Attachment: screenshot using the MUI basic.nsi and Slovak

Shows that this also affects the Slovak locale when using the MUI basic.nsi which comes with NSIS. I didn't see an existing bug for this in the NSIS bug tracker.

Comment 9

[Robert Kaiser]

I don't see any reason to give this special priority, but it's also not unwanted, so cancelling the wanted flag.

Comment 10

[Robert Kaiser]

Frank, any chance we can fix this?