408612 - Installing Flashgot Extension leaks an nsGlobalWindow and more

Status: RESOLVED FIXED

(Core :: General, defect, P3)

Description

[Carsten Book [:Tomcat]]

Attachment: leak log

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre)
Gecko/2007121517 Minefield/3.0b3pre

Steps to reproduce:
Installed Flashgot Extension https://addons.mozilla.org/en-US/firefox/addon/220 with Firefox restart
Firefox came up with Flashgot Welcome Page
Shutdown of Firefox
Leak

nsStringStats
 => mAllocCount:          37658
 => mReallocCount:         5631
 => mFreeCount:           36783  --  LEAKED 875 !!!
 => mShareCount:          40803
 => mAdoptCount:           7163
 => mAdoptFreeCount:       7156  --  LEAKED 7 !!!

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Please renom if there's a regression from Fx2.x branch ...

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Tomcat: do we leak just when flashgot is installed, or anytime afterwards when it is installed too?

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Is this just a shutdown leak, or does it increase when you use more browser windows?  (Probably easier to tell with leak-gauge logs, which will also tell you which windows leaked -- e.g., if it was the about:blank hidden window.)

If it's a shutdown leak, bug 398219 might help here.

Comment 4

[Carsten Book [:Tomcat]]

Attachment: new leak log with a new debug build

(In reply to comment #2)
> Tomcat: do we leak just when flashgot is installed, or anytime afterwards when
> it is installed too?
> 

its also afterwards when i have about:blank as homepage and not surfing or using other tabs. Created a new leak log.

Comment 5

[Mike Schroepfer]

+ing since Flashgot is a pretty common extension.  If this is just a shutdown leak we should minus

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This looks like it could be a shutdown leak. Tomcat, it would be great if you could whack at this a bit more and see if you can get it to leak more than 2 nsGlobalWindow

Comment 7

[Carsten Book [:Tomcat]]

This is now fixed by bug 412491 and Version 1.2.9. Verified while using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012113 Minefield/3.0b3pre