408660 - Should be able to set icons for special folders in the organizer

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Asaf Romano (gone)]

See organizer mockup. We should allow themes to set icons for special folders in the organizer (in particular, all the left pane queries).

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Mano, can we borrow Ryan's patch from bug 424951 here?

Comment 3

[Asaf Romano (gone)]

I already have a better fix in hand. patch coming.

Comment 4

[Asaf Romano (gone)]

Attachment: patch

Comment 5

[Asaf Romano (gone)]

Attachment: patch

Comment 6

[Dietrich Ayala (:dietrich)]

Comment on attachment 314201 [details] [diff] [review]
patch


>+        if (itemId != -1) {
>+          var oqAnno;
>+          try {
>+            oqAnno = PlacesUtils.annotations.getItemAnnotation(itemId, ORGANIZER_QUERY_ANNO);
>+            properties.push(this._getAtomFor("OrganizerQuery_" + oqAnno));
>+            Components.utils.reportError(oqAnno);

what's up with this last line?

also, please document the values somewhere.

Comment 7

[Asaf Romano (gone)]

will remove it on checkin.

Comment 8

[Dietrich Ayala (:dietrich)]

Comment on attachment 314201 [details] [diff] [review]
patch

r=me w/ that line removed

Comment 9

[Asaf Romano (gone)]

mozilla/browser/components/places/content/treeView.js 1.61

Comment 10

[Tracy Walker [:tracy]]

verified with: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008041804 Minefield/3.0pre

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv