408812 - AIX Compilation error for trunk build source nsThebesRegion.cpp : ./dist/include/gfx/nsRegion.h", line 85.18: 1540-0723 (S) The inline function "void operator delete(void *, size_t)" is referenced, but it is not defined.

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Shailen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11

While compiling trunk build on AIX, getting below compilation error - 

"../../../dist/include/gfx/nsRegion.h", line 85.18: 1540-0723 (S) The inline function "void operator delete(void *, size_t)" is referenced, but it is not defined.

The nsRegion::RgnRect::operator delete is defined in nsRegion.cpp and it is being  being referenced in nsThebesRegion.cpp. The sThebesRegion.cpp does inlcude the "nsThebesRegion.h" which inturn includes "nsRegion.h", not able to find the function definition for nsRegion::RgnRect::operator delete.



Reproducible: Always

Steps to Reproduce:
1.Build Mozilla Firefox Trunk build on AIX with Gnome 2.12 RPMS of 64 bit
version.
2.
3.
Actual Results:  
Build fails with the above error.

Expected Results:  
No build failure

Comment 1

[Shailen]

Attachment: Patch V1

Moving the inline function definition for 

   1. nsRegion::RgnRect::operator delete
   2. nsRegion::RgnRect::operator new 

from nsRegion.cpp to nsRegion.h

Also the above change resulting in moving the class declaration for RgnRectMemoryAllocator from nsRegion.cpp to nsRegion.h.

Comment 2

[Shailen]

Attachment: Patch V2

Small correction (in the comments for the code)for the previous attachment

Comment 3

[Benjamin Smedberg]

Comment on attachment 293659 [details] [diff] [review]
Patch V2

I am not a gfx peer. Seems to me that it might be better to make operator new/delete not inline at all.

Comment 4

[Shailen]

Attachment: Patch V3

Removing inline keyword for new/delete seem to be working fine.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 293811 [details] [diff] [review]
Patch V3

That's fine; I'm pretty sure 'inline' is bogus there anyway.

Comment 6

[Reed Loden [:reed]]

Comment on attachment 293811 [details] [diff] [review]
Patch V3

vlad's r= is enough, as per recent commits (http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Fgfx&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=month&mindate=&maxdate=&cvsroot=%2Fcvsroot), especially for a build fix.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 293811 [details] [diff] [review]
Patch V3

a=beltzner for 1.9

Comment 8

[Reed Loden [:reed]]

Checking in gfx/public/nsRegion.h;
/cvsroot/mozilla/gfx/public/nsRegion.h,v  <--  nsRegion.h
new revision: 1.8; previous revision: 1.7
done
Checking in gfx/src/nsRegion.cpp;
/cvsroot/mozilla/gfx/src/nsRegion.cpp,v  <--  nsRegion.cpp
new revision: 1.23; previous revision: 1.22
done