Closed Bug 408856 Opened 18 years ago Closed 18 years ago

Various parts of mailnews incorrectly do_CreateInstance for nsIProxyObjectManager rather than do_GetService

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Assigned: prasad)

Details

Attachments

(1 file)

Subject says it all, when we're getting an nsIProxyObjectManager we should be using do_GetService, in various places we're using do_CreateInstance.
replaced do_CreateInstance with do_GetService for proxy object manager.
Attachment #293874 - Flags: review?(bugzilla)
Status: NEW → ASSIGNED
Attachment #293874 - Flags: review?(bugzilla) → review+
Attachment #293874 - Flags: superreview?(bienvenu)
Comment on attachment 293874 [details] [diff] [review] Get nsIProxyObjectManages using do_GetService thx for the patch
Attachment #293874 - Flags: superreview?(bienvenu) → superreview+
Mark, can you check-in this patch for me :)
Keywords: checkin-needed
(In reply to comment #3) > Mark, can you check-in this patch for me :) > Checking in mailnews/addrbook/src/nsAbLDAPDirectoryModify.cpp; /cvsroot/mozilla/mailnews/addrbook/src/nsAbLDAPDirectoryModify.cpp,v <-- nsAbLDAPDirectoryModify.cpp new revision: 1.3; previous revision: 1.2 done Checking in mailnews/addrbook/src/nsAbLDAPListenerBase.cpp; /cvsroot/mozilla/mailnews/addrbook/src/nsAbLDAPListenerBase.cpp,v <-- nsAbLDAPListenerBase.cpp new revision: 1.10; previous revision: 1.9 done Checking in mailnews/addrbook/src/nsAbRDFDataSource.cpp; /cvsroot/mozilla/mailnews/addrbook/src/nsAbRDFDataSource.cpp,v <-- nsAbRDFDataSource.cpp new revision: 1.35; previous revision: 1.34 done Checking in mailnews/addrbook/src/nsAddrDatabase.cpp; /cvsroot/mozilla/mailnews/addrbook/src/nsAddrDatabase.cpp,v <-- nsAddrDatabase.cpp new revision: 1.161; previous revision: 1.160 done Checking in mailnews/addrbook/src/nsLDAPAutoCompleteSession.cpp; /cvsroot/mozilla/mailnews/addrbook/src/nsLDAPAutoCompleteSession.cpp,v <-- nsLDAPAutoCompleteSession.cpp new revision: 1.54; previous revision: 1.53 done Checking in mailnews/import/src/nsImportMail.cpp; /cvsroot/mozilla/mailnews/import/src/nsImportMail.cpp,v <-- nsImportMail.cpp new revision: 1.76; previous revision: 1.75 done Checking in mailnews/import/src/nsImportStringBundle.cpp; /cvsroot/mozilla/mailnews/import/src/nsImportStringBundle.cpp,v <-- nsImportStringBundle.cpp new revision: 1.25; previous revision: 1.24 done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: