408925 - XRE_InitEmbedding does not initialize properly profilelock and gDirServiceProvider

Status: RESOLVED FIXED

Description

[Oleg Romashin (:romaxa)]

Created attachment 293782 [details] [diff] [review]
Probably this is proper fix

After calling 
XRE_LockProfileDirectory
XRE_InitEmbedding

gDirServiceProvider not initialized properly and some components like extensionManager cannot startup properly with broken gDirServiceProvider.

Comment 1

[Benjamin Smedberg]

Comment on attachment 293782 [details] [diff] [review]
Probably this is proper fix

This is not correct. The call to XRE_LockProfileDirectory does not *set* the profile directory. What sets the profile directory is the application directory provider. nsXREDirProvider should ask the application directory provider for the profile directories before using the builtin ones... or perhaps ask once and cache it in the members it uses internally.

Comment 2

[Oleg Romashin (:romaxa)]

Created attachment 324284 [details] [diff] [review]
Another way to fix this problem.

Comment 3

[Oleg Romashin (:romaxa)]

Created attachment 325926 [details] [diff] [review]
Request mProfileDir from external dirProvider

This is attempt to request mProfileDir from external dirService provider.

Comment 4

[Oleg Romashin (:romaxa)]

Created attachment 325927 [details] [diff] [review]
One patch for GtkMozEmbed dir provider and XREDirProvider

Comment 5

[Oleg Romashin (:romaxa)]

Maybe instead !strcmp(aKey, NS_*_PROFILE_*_DIR)
better to compare key with "Prof*"

Comment 6

[Benjamin Smedberg]

Comment on attachment 325927 [details] [diff] [review]
One patch for GtkMozEmbed dir provider and XREDirProvider

>--- mozilla/toolkit/xre/nsXREDirProvider.cpp.orig	2008-06-16 09:16:18.000000000 +0300
>+++ mozilla/toolkit/xre/nsXREDirProvider.cpp	2008-06-20 08:28:21.000000000 +0300


>+  if (!mProfileDir) {
>+    nsCOMPtr<nsIDirectoryServiceProvider2> appP2(do_QueryInterface(mAppProvider));
>+    if (appP2) {
>+      PRBool per;
>+      appP2->GetFile(NS_APP_USER_PROFILE_50_DIR, &per, getter_AddRefs(mProfileDir));

1) you don't need to QI to nsIDirectoryServiceProvider2, just nsIDirectoryServiceProvider
2) Please assert that, if GetFile succeeded, "per" is true... if we can't persist the profile directory, all sorts of bad things could happen.

Comment 7

[Oleg Romashin (:romaxa)]

Created attachment 330844 [details] [diff] [review]
Comment 6 fixes

Comment 8

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/index.cgi/mozilla-central/rev/1b2644a57966