Closed Bug 408982 Opened 17 years ago Closed 17 years ago

nsContextMenu.js should use localized ellipsis (intl.ellipsis) instead of "...".

Categories

(Firefox :: Menus, defect)

defect
Not set
minor

Tracking

()

RESOLVED DUPLICATE of bug 407481

People

(Reporter: masa141421356, Unassigned)

References

()

Details

(Keywords: l12y)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11

"Block Images from %s" context menu always uses "..." (THREE PERIODS).
Is should use localized ellipsis.


Reproducible: Always

Steps to Reproduce:
1.Go to web page that has long host name and IMG element.
2.Right click on image
3.Check context menu.
Actual Results:  
It bacames to "Block Images from XXXXXXXXXXXXXXXXXXXXXXX..."


Expected Results:  
It should use localized ellipsis (intl.ellipsis , added at Bug 403484)
OS: Windows XP → All
Hardware: PC → All
Version: unspecified → Trunk
Summary: "Block Images from %s" context menu item should localized ellipsis → "Block Images from %s" context menu item should use localized ellipsis when cropped
I think this bug is caused by hardcoded "..." in 
http://lxr.mozilla.org/mozilla/source/browser/base/content/nsContextMenu.js#250-253
----------------
250         var shortenedUriHost = hostLabel.replace(/^www\./i,"");
251         if (shortenedUriHost.length > 15)
252           shortenedUriHost = shortenedUriHost.substr(0,15) + "...";
253         blockImage.label = gNavigatorBundle.getFormattedString("blockImages", [shortenedUriHost]);
-----------------
Keywords: l12y
There is same bug in Line 1038 of nsContextMenu.js .
It is uses to create ContextMenu Item to search selected text by search engine:
 Search XXXXXXX(Serach engine name) for  "XXXXXXXXXXXXXXX..." 
----------------
1034     if (!selectedText)
1035       return false;
1036 
1037     if (selectedText.length > 15)
1038       selectedText = selectedText.substr(0,15) + "...";
Summary: "Block Images from %s" context menu item should use localized ellipsis when cropped → dynamically created contextmenu items should use localized ellipsis when cropped
Summary: dynamically created contextmenu items should use localized ellipsis when cropped → nsContextMenu.js should use localized ellipsis (intl.ellipsis) instead of "...".
Status: UNCONFIRMED → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.