408990 - gtk: expander in treeview is not the correct size

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[u294409]

User-Agent:       Opera/9.24 (X11; Linux i686; U; pl; Fedora/8 (Werewolf))
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007121008 Minefield/3.0b2pre

component on the left should look like gtktreeview, but does not.

Reproducible: Always

Steps to Reproduce:
1. open all history
Actual Results:  
component on the left should look like gtktreeview, but does not.

Expected Results:  
component on the left looks like gtktreeview, but does not.

Comment 1

[u294409]

Attachment: actual tree

look at arrows - they look strange (don't know why) and they have no hover effect and they're not animated.

Comment 2

[u294409]

Attachment: gtk tree example

notice tree elements - they look like menu items.

Comment 3

[Michael Ventnor]

The size issue would be because we use the expander element and not the treeview's internal expander. As for hover and active feedback that isn't fixable for Firefox 3 because we don't construct a frame for every expander (I assume for performance reasons) so getting the events for an individual expander is impossible.

I can fix the size issue though.

Comment 4

[Michael Ventnor]

Attachment: Patch

This seems to work.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Shouldn't we rename these functions to make it clear we're talking about a treeview expander, since GTK supports "normal" expanders that we might even want to use one day?

Comment 6

[Michael Ventnor]

Attachment: Patch 2

Keep around the regular expander code for when we want to use it.

Comment 7

[Reed Loden [:reed]]

Ventron, mind re-summarizing this bug for what you actually did?

Comment 8

[Reed Loden [:reed]]

Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.63; previous revision: 1.62
done
Checking in widget/src/gtk2/gtkdrawing.h;
/cvsroot/mozilla/widget/src/gtk2/gtkdrawing.h,v  <--  gtkdrawing.h
new revision: 1.48; previous revision: 1.47
done
Checking in widget/src/gtk2/nsNativeThemeGTK.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsNativeThemeGTK.cpp,v  <--  nsNativeThemeGTK.cpp
new revision: 1.131; previous revision: 1.130
done

Comment 9

[u294409]

Also, look at treeview elements. In native GTK they are not flat.

Comment 10

[u294409]

You've made summary wrong! Not the size is important but the style.

Comment 11

[Michael Ventnor]

Can you be more specific than that?

Comment 12

[u294409]

Compare the screenshots, man!

Comment 13

[Michael Ventnor]

Other than the expander size which was fixed what is wrong? You need to be specific if you want any help!

Comment 14

[Ian Spence]

He wants the tree items to be glossy. I was never able to get a working patch for it. If we ever got that working, TreeView widgets also have colors set for alternating items, which we could use in the download manager among other places

Comment 15

[Reed Loden [:reed]]

File a new bug for that. This bug is already fixed. Multiple patches in one bug causes problems.

Comment 16

[u294409]

I filed another bug some time ago and there's not interest...