409052 - decouple tinderbox server data from cgi directory

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[cls]

We discussed the issue of decoupling the tinderbox logs & other data from the tinderbox installation dir on IRC a few months ago.  This would allow tinderbox to be installed to a standard location while allowing the potentially gigs of logfiles to be stored in a different location (preferably one with more disk space).

Here's a quick-n-dirty way that allows the tree data to be stored elsewhere.  The trees would now live under TBOXDIR/trees/$tree instead of TBOXDIR/$tree .  All references to logfiles are prefixed with $::tree_dir which defaults to 'trees'.  For backwards compatibility, if "$::tree_dir/." isn't a directory, then $::tree_dir reverts back to '.'.   Using trees as a symlink, I was able to move the existing trees to a different partition.

Unfortunately, using 'trees' breaks backwards compatibility with the static pages.  Instead of being /tinderbox/SeaMonkey/ , they'll be /tinderbox/trees/SeaMonkey/.  This can be worked around with apache redirect magic but that's just annoying.

I haven't tested this yet but by changing $::data_dir in tbglobals.pl, we should be able to remove the need to write to the tinderbox cgi dir completely.

Comment 1

[cls]

Attachment: v1.0

Comment 2

[cls]

Checking in webtools/tinderbox/README;
/cvsroot/mozilla/webtools/tinderbox/README,v  <--  README
new revision: 1.15; previous revision: 1.14
done
Checking in webtools/tinderbox/addnote.cgi;
/cvsroot/mozilla/webtools/tinderbox/addnote.cgi,v  <--  addnote.cgi
new revision: 1.27; previous revision: 1.26
done
Checking in webtools/tinderbox/admintree.cgi;
/cvsroot/mozilla/webtools/tinderbox/admintree.cgi,v  <--  admintree.cgi
new revision: 1.37; previous revision: 1.36
done
Checking in webtools/tinderbox/buildwho.pl;
/cvsroot/mozilla/webtools/tinderbox/buildwho.pl,v  <--  buildwho.pl
new revision: 1.27; previous revision: 1.26
done
Checking in webtools/tinderbox/bustagestats.cgi;
/cvsroot/mozilla/webtools/tinderbox/bustagestats.cgi,v  <--  bustagestats.cgi
new revision: 1.11; previous revision: 1.10
done
Checking in webtools/tinderbox/checksetup.pl;
/cvsroot/mozilla/webtools/tinderbox/checksetup.pl,v  <--  checksetup.pl
new revision: 1.4; previous revision: 1.3
done
Checking in webtools/tinderbox/doadmin.cgi;
/cvsroot/mozilla/webtools/tinderbox/doadmin.cgi,v  <--  doadmin.cgi
new revision: 1.32; previous revision: 1.31
done
Checking in webtools/tinderbox/processbuild.pl;
/cvsroot/mozilla/webtools/tinderbox/processbuild.pl,v  <--  processbuild.pl
new revision: 1.71; previous revision: 1.70
done
Checking in webtools/tinderbox/scrape.pl;
/cvsroot/mozilla/webtools/tinderbox/scrape.pl,v  <--  scrape.pl
new revision: 1.16; previous revision: 1.15
done
Checking in webtools/tinderbox/showbuilds.pl;
/cvsroot/mozilla/webtools/tinderbox/showbuilds.pl,v  <--  showbuilds.pl
new revision: 1.33; previous revision: 1.32
done
Checking in webtools/tinderbox/showlog.cgi;
/cvsroot/mozilla/webtools/tinderbox/showlog.cgi,v  <--  showlog.cgi
new revision: 1.29; previous revision: 1.28
done
Checking in webtools/tinderbox/tbglobals.pl;
/cvsroot/mozilla/webtools/tinderbox/tbglobals.pl,v  <--  tbglobals.pl
new revision: 1.64; previous revision: 1.63
done
Checking in webtools/tinderbox/viewallnotes.cgi;
/cvsroot/mozilla/webtools/tinderbox/viewallnotes.cgi,v  <--  viewallnotes.cgi
new revision: 1.20; previous revision: 1.19
done
Checking in webtools/tinderbox/warnings.pl;
/cvsroot/mozilla/webtools/tinderbox/warnings.pl,v  <--  warnings.pl
new revision: 1.106; previous revision: 1.105
done

Comment 3

[cls]

Attachment: v2.0

I verified that you can point $::data_dir at a different location.  This patch allows the location to be set at install time.

Comment 4

[cls]

Checking in webtools/tinderbox/Makefile;
/cvsroot/mozilla/webtools/tinderbox/Makefile,v  <--  Makefile
new revision: 1.24; previous revision: 1.23
done
Checking in webtools/tinderbox/tbglobals.pl;
/cvsroot/mozilla/webtools/tinderbox/tbglobals.pl,v  <--  tbglobals.pl
new revision: 1.65; previous revision: 1.64
done

Comment 5

[cls]

Attachment: v3.0

Add $::tree_dir reference to fix log trimming.

/cvsroot/mozilla/webtools/tinderbox/tbglobals.pl,v  <--  tbglobals.pl
new revision: 1.68; previous revision: 1.67

Comment 6

[cls]

Attachment: v3.1

Fix clean.pl as well

Comment 7

[cls]

Checking in clean.pl;
/cvsroot/mozilla/webtools/tinderbox/clean.pl,v  <--  clean.pl
new revision: 1.16; previous revision: 1.15
done
Checking in tbglobals.pl;
/cvsroot/mozilla/webtools/tinderbox/tbglobals.pl,v  <--  tbglobals.pl
new revision: 1.69; previous revision: 1.68
done

Comment 8

[cls]

Search placeholder - tbox1_20080527_cls_branch