409093 - Revise All-Day item bindings in agenda/today pane

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Berend Cornelius]

The new agenda-pane uses the month-view-binding to represent allday-items. As I found out the architecture of this binding is not really to be uses outside a calendar view. This leads to some problems such as:
- The richlistitems in the agenda-pane do not provide a tooltip.
- Clicking on an allday-richlist item leads to an error in "calendar-view-core, line 256".
- The shadows of the month-view-binding are currently removed by a method and should probably better be set by an attribute.
- The label of the month-view-binding does not give any information about the date which is bad when it is within ghe next-Week period.

Comment 1

[Simon Paquet [:sipaq]]

This bug is not important enough to warrant wanted0.8 status. 

We would however take a fix for this bug into 0.8, if such a fix materializes.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Might relieve the situation if you set up a calendar view controller (probably the one in calendarViews.js) and a calICalendarView for the agenda pane?

Comment 3

[Pete Riley]

(In reply to comment #0)
> The new agenda-pane uses the month-view-binding to represent allday-items.

Eliminating this would also allow us to use a small font in month view (because of limited space) and use the normal size in the agenda.

However, please let us apply css styles to the all-day events in the agenda like we can now via month view.  I guess this would require us to maintain two different sets of rules in our userchrome.css (one for events in month view and another for the same events in the agenda)?  I have a lot of rules and this would not be ideal.

Maybe I'm repeating what Philipp said in comment 2, but ideally the agenda would inherit the relevant rules from month view (or vice versa).  Or maybe there could be an abstract parent class where I can define my rules and then both the month view and the agenda inherit from it.  This way I would only need to define my rules once and then override one css rule in the agenda for the font size.

Comment 4

[Markus Adrario [:Taraman]]

I don't know when this happened, but in the meanwhile, the today-pane has its own binding for allday-items [1]
For me everything mentioned above works fine with these.

Therefore --> fixed

[1]: http://mxr.mozilla.org/comm-central/source/calendar/base/content/agenda-listbox.xml#84