Closed Bug 409105 Opened 17 years ago Closed 17 years ago

Just finished download shows start time instead of completed time

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.9beta3

People

(Reporter: stephend, Assigned: Mardak)

Details

Attachments

(2 files)

Mardak and I noticed a problem with Download Manager's date-display code.

Specifically, downloads are sorted in the in-progress UI by their start date/time, but when finished downloading, aren't sorted by their completed time until you close and reopen the DM window.
Just to make sure, can you double check if the date shown is the start time or the completed time? Just-completed downloads end up at the top after the active ones, so I think it's just the time that's displayed is wrong.

Because if you close and reopen the list, the items are in the same order, but the time shown is different.
Summary: Downloads should always be sorted by completed time → Just finished download shows start time instead of completed time
Attached patch v1Splinter Review
We skip updating the time if it's in progress, but the download state isn't set until after the call to downloadCompleted.
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #293999 - Flags: review?(comrade693+bmo)
Comment on attachment 293999 [details] [diff] [review]
v1

r=sdwilsh
Attachment #293999 - Flags: review?(comrade693+bmo)
Attachment #293999 - Flags: review+
Attachment #293999 - Flags: approval1.9?
Comment on attachment 293999 [details] [diff] [review]
v1

a=beltzner for 1.9
Attachment #293999 - Flags: approval1.9? → approval1.9+
Checking in toolkit/mozapps/downloads/content/DownloadProgressListener.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/DownloadProgressListener.js,v  <--  DownloadProgressListener.js
new revision: 1.35; previous revision: 1.34
done
Checking in toolkit/mozapps/downloads/content/downloads.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.js,v  <--  downloads.js
new revision: 1.123; previous revision: 1.122
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-litmus?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11
https://litmus.mozilla.org/show_test.cgi?id=5059

in-litmus+

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2007123104 Minefield/3.0b3pre

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2007123104 Minefield/3.0b3pre

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2007123105 Minefield/3.0b3pre

Verified FIXED
Status: RESOLVED → VERIFIED
Flags: in-litmus? → in-litmus+
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: