40917 - nsDocument::GetDoctype() fails if doctype not first node

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

There is a small typo in the for loop that goes through the prolog looking for 
doctype node: we always get the 0th node!

Comment 1

[Johnny Stenback (:jst)]

This is embarrassing, nsbeta2+ please?

Index: layout/base/src/nsDocument.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/base/src/nsDocument.cpp,v
retrieving revision 3.218
diff -u -r3.218 nsDocument.cpp
--- nsDocument.cpp      2000/05/27 22:39:39     3.218
+++ nsDocument.cpp      2000/05/29 17:44:58
@@ -1983,7 +1983,7 @@
     PRInt32 i, count = mProlog->Count();
 
     for (i = 0; i < count; i++) {
-      nsIContent* content = (nsIContent *)mProlog->ElementAt(0);
+      nsIContent* content = (nsIContent *)mProlog->ElementAt(i);
 
       if (!content)
         continue;

Comment 2

[Kathleen :Brade]

In support of getting this fix in for nsbeta2:  this will probably break some 
things in Composer which rely on GetDoctype (when editing a file with the doctype 
not the first node)

Comment 3

[rickg]

No need for embarassment -- nsbeta2+ approved.

Comment 4

[Johnny Stenback (:jst)]

Thanks Rick, fix checked in.

Comment 5

[Jan Carpenter]

sounds like a code fix.  heikki, can you verify?

Comment 6

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Marking verified.