409220 - Warn on use of getBoxObjectFor

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Matthew Mastracci]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.5) Gecko/20070718 Fedora/2.0.0.5-1.fc7 Firefox/2.0.0.5
Build Identifier: n/a

Since getBoxObjectFor was never designed for general use and (at some point) will be deprecated, it would be a good idea to start warning when sites are using it now.

Reproducible: Always

Steps to Reproduce:
1.  Call document.getBoxObjectFor(element)

Actual Results:  
Call succeeds, no warning

Expected Results:  
Call succeeds, warning placed in error log that method is deprecated, please use getBoundingClientRects.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

We could perhaps do this for 1.9 in those cases when element isn't a xul element.

Comment 2

[Flummox]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008030804 Minefield/3.0b5pre ID:2008030804

I just got a warning in the Error Console and an exception when visiting:
http://66.102.9.104/search?q=cache:5y5AbM_tNygJ:boardreader.com

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

We do warn nowadays when using getBoxObjectFor for non-xul elements.

Comment 4

[Gérard Talbot]

Hello all,

I do not understand why when visiting the webpage
http://www.gtalbot.org/BugzillaSection/Bug195867GDR_WindowOpen.html
I should get a warning stating that
{
The use of « getBoxObjectFor() » is deprecated. Try to use the fonction « element.getBoundingClientRect() » if possible.
}
when the webpage is not using getBoxObjectFor() anywhere to begin with.

The Bug195867GDR_WindowOpen.html uses an 
<object data="../GRAPHICS/GIF/FirefoxChromeToolbarsDescription7a.gif" type="image/gif" width="840" height="620" usemap="#MapForImage" ...>
as an image map ... which I suppose is why I get such warning.

I have searched for a duplicate and none corresponds appropriately except this bug.

I am using (reproducible 100% with) Firefox 3.0 RC1 rv: 1.9 build 2008051206 French localization under XP Pro SP3 here.

Should I create a separate bug for this?

Comment 5

[Gérard Talbot]

I get the same warning message when visiting
http://www.gtalbot.org/BugzillaSection/Bug374183PlayingVideoWithWindowsMediaPlayer11.html

Comment 6

[Gérard Talbot]

A quick reduced testcase:

http://www.gtalbot.org/BugzillaSection/Bug409220WarnUseGetBoxObjectFor.html

Steps:
- Use Firefox 3.0 RC1 rv: 1.9 build 2008051206
- Open and clear Error console
- load 
http://www.gtalbot.org/BugzillaSection/Bug409220WarnUseGetBoxObjectFor.html

Expected results: no warning message in Error console

Actual results: 
{
The use of « getBoxObjectFor() » is deprecated. Try to use the fonction
« element.getBoundingClientRect() » if possible.
}
warning message appears in Error console

Comment 7

[Boris Zbarsky [:bzbarsky]]

Please make sure you're testing in safe mode?  I would fully expect that warning if you have an extension that binds XBL to <objects> and the XBL uses getBoxObjectFor (e.g. adblock and so forth).  I don't see that warning on that page.

Comment 8

[Gérard Talbot]

> an extension that binds XBL to <objects> and the XBL uses
> getBoxObjectFor (e.g. adblock and so forth).

Hello Boris,

You are correct and on the spot: it was AdblockPlus 0.7.5.4. Disactivating AdblockPlus will no longer generates such warning messages on <object>s. Thank you!

Comment 9

[Gérard Talbot]

I have created/opened a bugfile at mozdev regarding AdblockPlus
Bug 19126: getBoxObjectFor() deprecated, use element.getBoundingClientRect() warning message
https://www.mozdev.org/bugs/show_bug.cgi?id=19126
so that this issue be fixed over there.