409221 - JSS test tries to use amd64 Java on sparcv9 for 64bit test

Status: RESOLVED FIXED

(JSS Graveyard :: Tests, defect, P2)

Description

[Christophe Ravel]

Thu Dec 20 08:36:31 PST 2007: Start JSS tests for SunOS5.10_64_DBG
================
DEBUG in SunOS
DEBUG java=/share/builds/components/jdk/1.5.0_09/SunOS64/jre/bin/java
DEBUG cpu=sparcv9

DEBUG java=/share/builds/components/jdk/1.5.0_09/SunOS64/jre/bin/amd64/java
'/share/builds/components/jdk/1.5.0_09/SunOS64/jre/bin/amd64/java' does not exist
Thu Dec 20 08:36:31 PST 2007: End JSS tests for SunOS5.10_64_DBG

Comment 1

[Christophe Ravel]

There are 2 issues with the following code:

    #
    # Use 64-bit Java on AMD64.
    #

    my $java_64bit = 0;
    if ($osname eq "SunOS") {
        if ($ENV{USE_64}) {
            my $cpu = `/usr/bin/isainfo -n`;
            if ($cpu == "amd64") {
                $java = "$ENV{JAVA_HOME}/jre/bin/amd64/java$exe_suffix";
                $java_64bit = 1;
            }
        }
    }

Issue #1: $cpu needs to be chomp'd after `/usr/bin/isainfo -n`
issue #2: the comparison operator for strings is "eq", not "=="

I am wondering why this ever worked before today...

Comment 2

[Christophe Ravel]

Attachment: fixes the bug

Comment 3

[Christophe Ravel]

Patch tested on Solaris SPARC and Solaris x86

Comment 4

[Christophe Ravel]

Committed on the trunk:

Checking in all.pl;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/all.pl,v  <--  all.pl
new revision: 1.50; previous revision: 1.49
done