409284 - bloatdiff.pl should catch basic errors

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Chris Cooper [:coop] (he/him)]

bloatdiff.pl doesn't do any checking on the command-line args it's passed, so it merrily goes about its calculations even when it has no hope of success. 

Patch forthcoming.

Comment 1

[Chris Cooper [:coop] (he/him)]

Attachment: Check that supplied files exist and are not empty.

Also:
- comment out unused LABEL var
- add usage() sub which essentially spits out the old file header
- add some usage hints on failure

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 294098 [details] [diff] [review]
Check that supplied files exist and are not empty.

>Index: bloatdiff.pl
...
>+# bloatdiff.pl - munges the output from
> #   XPCOM_MEM_BLOAT_LOG=1; mozilla-bin -f bloaturls.txt

I wonder if this is still true - tinderbox does 
  .../obj/dist/bin/firefox-bin -P default resource:///res/bloatcycle.html
for Firefox, Seamonkey, and TestGtkEmbed, otherwise falls back to the -f method.

r+ for the rest.

Comment 3

[Chris Cooper [:coop] (he/him)]

(In reply to comment #2)

> I wonder if this is still true - tinderbox does 
>   .../obj/dist/bin/firefox-bin -P default resource:///res/bloatcycle.html
> for Firefox, Seamonkey, and TestGtkEmbed, otherwise falls back to the -f
> method.

While not strictly untrue, certainly out-of-date. I just wrapped the existing file header here into a usage() sub, but you're right. I should update it with info about how the script is currently used.

Comment 4

[Chris Cooper [:coop] (he/him)]

Checking in bloatdiff.pl;
/cvsroot/mozilla/tools/tinderbox/bloatdiff.pl,v  <--  bloatdiff.pl
new revision: 1.21; previous revision: 1.20
done