From bug 397655 comment 39: * default window size should be 485 width by 300 height - show 5.5 downloads by default - golden ratio - wide enough to show long file names - white space to allow scanning of dates
Created attachment 294141 [details] [diff] [review] v1
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #294141 - Flags: review?(comrade693+bmo)
Comment on attachment 294141 [details] [diff] [review] v1 Change the string, with a comment on how big it aught to be and why. Also, this won't do anything to existing profiles - just want people to be aware of that.
Attachment #294141 - Flags: review?(comrade693+bmo) → review-
Just making sure, we have this localizable because strings are probably different sizes in other languages.
I don't see what I'm supposed to comment here.. The height of the downloads are fixed across locales so 300px fits 5.5 downloads. If we want the golden ratio it'll need to be 485px wide. Do locales even need to switch from the old value?
well, 300px is localizable 485 px is localizable, I had to figure out what's really happening and intended to comment. It might be that we don't want to have this localizable, from the comments, but I have no idea if that'd bust locales or not.
Created attachment 299428 [details] [diff] [review] v1.1 Commented and renamed to window.width2
Attachment #299428 - Flags: review?(sdwilsh)
Comment on attachment 299428 [details] [diff] [review] v1.1 r=sdwilsh
Attachment #299428 - Flags: review?(sdwilsh) → review+
Comment on attachment 299428 [details] [diff] [review] v1.1 Requesting approval for "string" changes (it's a number) and adding LOCALIZATION NOTE comments
Attachment #299428 - Flags: approval1.9?
Checking in toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd; /cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.dtd,v <-- downloads.dtd new revision: 1.22; previous revision: 1.21 done Checking in toolkit/mozapps/downloads/content/downloads.xul; /cvsroot/mozilla/toolkit/mozapps/downloads/content/downloads.xul,v <-- downloads.xul new revision: 1.45; previous revision: 1.44 done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M11
Note, I had preferred window2.width to window.width2. Suffixes to key names are usually more important to tools than prefixes. Not sure if this patch really required a key name change, a simple script to check the source files for offending localizations would have been enough, I think, plus the comment.
You need to log in before you can comment on or make changes to this bug.