Support "highlight all" in the find bar



Camino Graveyard
Toolbars & Menus
10 years ago
7 years ago


(Reporter: Samuel Sidler (old account; do not CC), Unassigned)



We should support highlight all in the new find bar.

Comment 1

7 years ago
Does our current Find implementation even get the information it needs from Gecko to be able to do this? Or do we need Gecko to do something on the back end?
Hardware: PowerPC → All
I remember our discussing this with pink and smorgan back when pink implemented the Find bar (bug 258211, but it's not in there);  iirc, there isn't Core support for this.

I believe Firefox implements it by looping through the DOM in JS (i.e., exactly the same as the "Highlight" bookmarklet), which isn't even close to performant on large pages.

Comment 3

7 years ago
(In reply to comment #2)
> iirc, there isn't Core support for this.

That's what I was afraid of. Has there been a bug filed about *properly* supporting this (i.e., doing something other than an awful JS loop hack) in Core?

As a bonus, the patch for such a bug would theoretically let Firefox have a performant implementation, too :-p
You need to log in before you can comment on or make changes to this bug.