409375 - English text runs reversed when setting plaintext mail message to RTL direction

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P1)

Description

[Eyal Rozenberg]

Attachment: incorrect rendering in RTL

Using SM trunk with BiDi Mail UI 0.8 (which does _not_ reverse text runs, it only sets the direction and encoding, and in this case does not set iso-8859).

I've noticed in recent weeks (after the period in which bug 387564 meant crashes when setting RTL, i.e. the period between 2007-10-19 and 2007-12-06) that for some plain text messages with both English and Hebrew text, setting the direction to RTL reverses the English text, i.e.

TXET WERBEH
English text blah blah

(which is the ok way to see this text in LTR)

becomes

           TXET WERBEH
halb halb txet hsilgnE

instead of 

           TXET WERBEH
English text blah blah

changing back to LTR, the problem goes away.

Comment 1

[Asaf Romano (gone)]

FYI, I couldn't reproduce this on data:text/plain,English ועברית after Switch Page Direction (utf-8 encoding).

Comment 2

[Eyal Rozenberg]

Attachment: folder with triggering message

Comment 3

[Eyal Rozenberg]

Reproduction instructions:

- Create a new profile 
- Start Seamonkey with the new profile
- Install BiDi Mail UI 0.8 from 
  http://downloads.mozdev.org/bidiui/latest/bidimailui_suite.xpi
- Exit Seamonkey
- Put the mbox file in attachment 294259 [details] in the new profile's 
  Local Folders directory
- Start Seamonkey
- Get yourself into mailnews somehow (why cant I skip creating 
  an account? :-( ...)
- Open the message in the folder you've added

That should do it.

Comment 4

[Eyal Rozenberg]

Oh, note of course that the first line of LTR text in the message doesn't get reversed, while the second line does.

Comment 5

[Uri Bernstein]

I can reproduce this in Firefox using data:text/plain,%0aEnglish%0a%0a (with bisi.browser.ui on, using "Switch Page Direction").

Comment 6

[Uri Bernstein]

The testcase worked correctly until 2007-08-15. Starting at 2007-08-16 (probably due to the checkin for bug 385270), it crashed, until 2007-09-27. Since 2007-09-28 (probably bug 393906), it no longer crashes, but reverses the text as described in the summary.

Comment 7

[Uri Bernstein]

(In reply to comment #6)
> Starting at 2007-08-16
> (probably due to the checkin for bug 385270), it crashed, until 2007-09-27.

This crash was reported as bug 394820.

Comment 8

[Simon Montagu :smontagu]

Attachment: Possible patch

This is really a correction to the patch for bug 406675. That didn't take into account that |frame| before entering EnsureBidiContinuation isn't always the frame which the continuation frame will be created from.

This patch fixes this bug, but it has effects on bug 409513 which I haven't fully analysed, and it's probably better to fix both together.

Comment 10

[Simon Montagu :smontagu]

Attachment: Better patch

This version removes the assertion in bug 409513 without causing any new ones.

Comment 11

[Simon Montagu :smontagu]

Attachment: With better documentation

Comment 12

[Simon Montagu :smontagu]

Checked in with reftest based on comment 5

Comment 13

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).