Closed
Bug 409376
Opened 17 years ago
Closed 17 years ago
getScreenCTM testcase fails on reload
Categories
(Core :: SVG, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: longsonr, Assigned: longsonr)
References
()
Details
(Keywords: regression, testcase)
Attachments
(1 file, 1 obsolete file)
3.98 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
Unlike bug 314214 the testcase in the URL does not have percentage types. If you click shift reload then everything is fine. You get a Reflow which initialises the viewport size and then the onload which works. When simply clicking on refresh things happen in the opposite order, you get the onload which fails as the viewport size is uninitialised (zero actually) and then the Reflow which initialises the viewport size too late. This works in Firefox 2, but then that doesn't do reflow in the same way.
Comment 1•17 years ago
|
||
Does the result of getScreenCTM depend on layout? If so, shouldn't it be flushing layout?
Flags: blocking1.9?
Assignee | ||
Comment 2•17 years ago
|
||
Spot on Boris. I am all right using the ownerDoc rather than the currentDoc for the flush aren't I.
Assignee: nobody → longsonr
Status: NEW → ASSIGNED
Attachment #294277 -
Flags: superreview?(bzbarsky)
Attachment #294277 -
Flags: review?(bzbarsky)
Comment 3•17 years ago
|
||
Comment on attachment 294277 [details] [diff] [review] patch No, you really want to use the current doc, not the owner doc. Furthermore, the flush can run arbitrary script, so you shouldn't really assume that things like the owner doc stay the same across the flush...
Attachment #294277 -
Flags: superreview?(bzbarsky)
Attachment #294277 -
Flags: superreview-
Attachment #294277 -
Flags: review?(bzbarsky)
Attachment #294277 -
Flags: review-
Assignee | ||
Comment 4•17 years ago
|
||
Attachment #294277 -
Attachment is obsolete: true
Attachment #294288 -
Flags: superreview?(bzbarsky)
Attachment #294288 -
Flags: review?(bzbarsky)
Comment 5•17 years ago
|
||
Comment on attachment 294288 [details] [diff] [review] currentDoc Looks great. This method isn't called from layout code, right?
Attachment #294288 -
Flags: superreview?(bzbarsky)
Attachment #294288 -
Flags: superreview+
Attachment #294288 -
Flags: review?(bzbarsky)
Attachment #294288 -
Flags: review+
Assignee | ||
Comment 6•17 years ago
|
||
The methods are part of the SVG DOM and called from javascript.
Assignee | ||
Updated•17 years ago
|
Attachment #294288 -
Flags: approval1.9?
Assignee | ||
Comment 7•17 years ago
|
||
In case that wasn't a clear enough answer. No these methods are not called from layout code.
Comment 8•17 years ago
|
||
Comment on attachment 294288 [details] [diff] [review] currentDoc a=beltzner for 1.9
Attachment #294288 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 9•17 years ago
|
||
checked in
Comment 10•17 years ago
|
||
verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008010211 Minefield/3.0b3pre.
Flags: in-litmus?
Comment 11•17 years ago
|
||
https://litmus.mozilla.org/show_test.cgi?id=5068 has been added to the Litmus test suite.
Status: RESOLVED → VERIFIED
Flags: in-litmus? → in-litmus+
Comment 12•17 years ago
|
||
I just noticed that when you load that URL you do get this error in the console - I just wanted to note it: Error: uncaught exception: [Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIDOMSVGLocatable.farthestViewportElement]" nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)" location: "JS frame :: http://www.w3.org/Graphics/SVG/Test/20061213/svggen/types-basicDOM-01-b.svg :: testSVGLocatable :: line 33" data: no].
Assignee | ||
Comment 13•17 years ago
|
||
Neither GetFarthestViewport nor GetNearestViewportElement are implemented (both are use on that page). I don't think there is a bug for that, so feel free to raise one if you wish.
Assignee | ||
Comment 14•17 years ago
|
||
raised bug 410811 for comment 12.
Updated•17 years ago
|
Flags: blocking1.9?
You need to log in
before you can comment on or make changes to this bug.
Description
•