409376 - getScreenCTM testcase fails on reload

Status: VERIFIED FIXED

(Core :: SVG, defect)

Description

[Robert Longson [:longsonr]]

Unlike bug 314214 the testcase in the URL does not have percentage types.

If you click shift reload then everything is fine. You get a Reflow which initialises the viewport size and then the onload which works.

When simply clicking on refresh things happen in the opposite order, you get the onload which fails as the viewport size is uninitialised (zero actually) and then the Reflow which initialises the viewport size too late.

This works in Firefox 2, but then that doesn't do reflow in the same way.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Does the result of getScreenCTM depend on layout?  If so, shouldn't it be flushing layout?

Comment 2

[Robert Longson [:longsonr]]

Attachment: patch

Spot on Boris. I am all right using the ownerDoc rather than the currentDoc for the flush aren't I.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 294277 [details] [diff] [review]
patch

No, you really want to use the current doc, not the owner doc.  Furthermore, the flush can run arbitrary script, so you shouldn't really assume that things like the owner doc stay the same across the flush...

Comment 4

[Robert Longson [:longsonr]]

Attachment: currentDoc

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 294288 [details] [diff] [review]
currentDoc

Looks great.

This method isn't called from layout code, right?

Comment 6

[Robert Longson [:longsonr]]

The methods are part of the SVG DOM and called from javascript.

Comment 7

[Robert Longson [:longsonr]]

In case that wasn't a clear enough answer. No these methods are not called from layout code.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 294288 [details] [diff] [review]
currentDoc

a=beltzner for 1.9

Comment 9

[Robert Longson [:longsonr]]

checked in

Comment 10

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008010211 Minefield/3.0b3pre.

Comment 11

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=5068 has been added to the Litmus test suite.

Comment 12

[Marcia Knous [:marcia]]

I just noticed that when you load that URL you do get this error in the console - I just wanted to note it: Error: uncaught exception: [Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIDOMSVGLocatable.farthestViewportElement]"  nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame :: http://www.w3.org/Graphics/SVG/Test/20061213/svggen/types-basicDOM-01-b.svg :: testSVGLocatable :: line 33"  data: no].

Comment 13

[Robert Longson [:longsonr]]

Neither GetFarthestViewport nor GetNearestViewportElement are implemented (both are use on that page). I don't think there is a bug for that, so feel free to raise one if you wish.

Comment 14

[Robert Longson [:longsonr]]

raised bug 410811 for comment 12.