Closed
Bug 409451
Opened 17 years ago
Closed 17 years ago
TT: Remove now-defunct Multiname class to save 1k of code
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: stejohns, Assigned: stejohns)
Details
Attachments
(1 file)
|
710.11 KB,
patch
|
edwsmith
:
review+
treilly
:
review+
|
Details | Diff | Splinter Review |
The Multiname class was only being used to store the contents of a QName in Tamarin-Tracing. Rewriting most of QName in AS3 code, and sotring an explicit Name/NamespaceSet/Flags, allows us to remove the Multiname class and two subclasses, saving about 1k of compiled code.
|
Assignee | |
Comment 1•17 years ago
|
||
Attachment #294260 -
Flags: review?(edwsmith)
|
|
Assignee | |
Updated•17 years ago
|
Attachment #294260 -
Flags: review?(treilly)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 294260 [details] [diff] [review]
patch
Should we create a followup bug for consolodating and scrubbing the verbose-formatting code? (maybe including removing PrintWriter and friends in favor of a printf() style interface?)
do we still need QName_private__newQName() as a dedicated function or is there another existing native method that does the same thing: classself->newObject()
Attachment #294260 -
Flags: review?(edwsmith) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Re: newQName, yeah, there are several redundant native functions for doing this that could be consolidated into one. I'll do that in a future checkin.
Re: followup bug, sure, entered as https://bugzilla.mozilla.org/show_bug.cgi?id=410505
|
|
Assignee | |
Comment 4•17 years ago
|
||
pushed as 270:0693b5c81a84
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Attachment #294260 -
Flags: review?(treilly) → review+
|
||
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•