409472 - Possible leak of GtkTreeViewColumn

Status: NEW

(Core :: Widget: Gtk, defect, P5)

Description

[Ian Spence]

Feel free to mark this as stupid, but I'm not familiar with how gtk handles references.

We currently have the code

static gint
ensure_tree_header_cell_widget()
{
    if(!gTreeHeaderCellWidget) {
        GtkTreeViewColumn* treeViewColumn;
        ensure_tree_view_widget();

        treeViewColumn = gtk_tree_view_column_new();
        gtk_tree_view_column_set_title(treeViewColumn, "M");

        gtk_tree_view_append_column(GTK_TREE_VIEW(gTreeViewWidget), treeViewColumn);
        gTreeHeaderCellWidget = treeViewColumn->button;
        gtk_tree_view_column_set_sort_indicator(treeViewColumn, TRUE);
        gTreeHeaderSortArrowWidget = treeViewColumn->arrow;
    }
    return MOZ_GTK_SUCCESS;
}

While I know we no longer hold the pointer to treeViewColumn, I assume GTK still does. I'm not sure if setting gTreeViewWidget to NULL cleans this up

Comment 1

[Michael Ventnor]

This isn't a problem. I made the treeviewcolumn a global variable and tried to cast it after everything was destroyed. I got this:

(gecko:16496): GLib-GObject-WARNING **: invalid uninstantiatable type `(null)' in cast to `GtkWidget'

Comment 2

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1552613