409515 - Please enable Afrikaans (af) for Thunderbird 2 (MOZILLA_1_8_BRANCH)

Status: VERIFIED FIXED

(Thunderbird :: Build Config, defect)

Description

[Friedel Wolff]

Afrikaans translations for Thunderbird 2 has been updated (see bug 402054). Please enable it on the branch.

Comment 1

[Friedel Wolff]

Attachment: Patch to all-locales to enable Afrikaans (af)

Here is the patch to all-locales to enable Afrikaans, as requested in bug 402054.

Comment 2

[Axel Hecht [:Pike]]

This is a thunderbird proper bug, moving over there.

Friedel, did you try a pristine check-out from cvs with this patch applied?

Please request review on this patch before requesting approval, too, either from me or from bsmedberg (:bs completes).

Sorry for not flipping all switches, I'm on slow-holidays mode.

Comment 3

[Friedel Wolff]

Comment on attachment 294338 [details] [diff] [review]
Patch to all-locales to enable Afrikaans (af)

Asking for review as requested by Axel

Comment 4

[Friedel Wolff]

Thanks for moving the bug to the correct place. I also only returned from holiday today. Yes, the patch applies to current MOZILLA_1_8_BRANCH. (The last change was long ago: 2007/03/08 17:29:56,  bug 372145)

Comment 5

[Axel Hecht [:Pike]]

Back from vacation, taking this bug.

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 294338 [details] [diff] [review]
Patch to all-locales to enable Afrikaans (af)

r=me, a=me for enabling thunderbird builds on the branch.

Comment 7

[Axel Hecht [:Pike]]

Landed on branch.

Checking in all-locales;
/cvsroot/mozilla/mail/locales/all-locales,v  <--  all-locales
new revision: 1.15.2.10; previous revision: 1.15.2.9
done

Friedel, please verify the builds on all three platforms and give them all the QA your community can offer.

Do we have a dedicated tb2 af shipping bug yet?

Comment 8

[Friedel Wolff]

I created the shipping bug. See bug 413914. Nightly builds were done, so can this bug now be closed?

Comment 9

[Axel Hecht [:Pike]]

Yes, let's close it. Mind following up in the shipping bug with a comment on which platforms you tested?

Comment 10

[Al Billings [:abillings - ex-MoCo]]

Verified. We build Afrikaans for the TB 2.0.0.12 release.

Comment 11

[Al Billings [:abillings - ex-MoCo]]

Attachment: Potential Afrikaans menu issue

I see this partially unlocalized menu in the Afrikaans build. Is this by-design?

This is on OS X 10.5.2.

Comment 12

[Al Billings [:abillings - ex-MoCo]]

Reopening pending resolution of comment #11.

Comment 13

[Dwayne Bailey]

(In reply to comment #11)
> Created an attachment (id=305817) [details]
> Potential Afrikaans menu issue
> 
> I see this partially unlocalized menu in the Afrikaans build. Is this
> by-design?

Definitely not by design.  The only references I can find for those strings is in: en-US/browser/chrome/browser/baseMenuOverlay.dtd:<!ENTITY hideOtherAppsCmdMac.label      "Hide Others">

This is in the browser/ sub-directory which was unexpected.  We are busy investigating.

Comment 14

[Dwayne Bailey]

CVS tag shows that l10n/af/browser/chrome/browser/baseMenuOverlay.dtd exists and is tagged THUNDERBIRD_2_0_0_12_RELEASE (1.1.2.2) and MOZILLA_1_8_BRANCH

Comment 15

[Alexander L. Slovesnik]

(In reply to comment #13)
> Definitely not by design.  The only references I can find for those strings is
> in: en-US/browser/chrome/browser/baseMenuOverlay.dtd:<!ENTITY
> hideOtherAppsCmdMac.label      "Hide Others">
> 
> This is in the browser/ sub-directory which was unexpected.  We are busy
> investigating.
> 
Actually it's by OS X design. Please take a look at Bug 410658 comment #21  

Comment 16

[Axel Hecht [:Pike]]

Resolving again, see further discussion in bug 410658.