409541 - Location bar / Search bar separator too high

Status: RESOLVED DUPLICATE of bug 393718

(Firefox :: Shell Integration, defect)

Description

[Michael Monreal [:micmon]]

Attachment: Screenshot/Mockup

The separator in the toolbar between the location bar and the search bar now has a very nice native look. But it is a bit to high. With the clearlooks theme, it should display 6 rows of dots for example, not 10. See screenshot attachment for a mockup.

Comment 1

[Ian Spence]

The 6 rows is just some arbitrary number that happened when they decided that specific bar should be 24px tall by default.

So at least in theory, adding 

toolbar > splitter { height: 24px; }

is the fix you want (it'll probably turn out to be 22px)

Comment 2

[Michael Monreal [:micmon]]

Ian, I tried this, also #urlbar-search-splitter { height: 20px !important; }

But the height is still 30px... why is the value not changed?

Comment 3

[Ian Spence]

#urlbar-search-splitter {
  margin-top: 10px !important;
  margin-bottom: 10px !important;
}

Achieves something close, although you likely want to make those ~8px each

Comment 4

[Michael Monreal [:micmon]]

Thanks Ian!

It actually looks best with 3px I think, because the FF toolbar is higher than the panel which I was comparing to.

Comment 5

[Michael Monreal [:micmon]]

Has the display of the separator been disabled in trunk now? I can't see it in the latest nightlies. If this was intentional and is going to stay this way, this bug can be closed.

Comment 6

[Julien "_FrnchFrgg_" RIVAUD]

Yes, it's intentionnal, see bug 393718, but it may change. It's probably good to make this bug a duplicate of 393718, and tweak the height there if it is made visible again.

Comment 7

[Michael Monreal [:micmon]]

Thanks for pointing out. I actually like the look we currently have. If the splitter returns, the height should be shorter, right. If not, it's fine this way (perhaps the gap between the two widgets could be a bit smaller... but just 1px I think)