Closed
Bug 409545
Opened 17 years ago
Closed 16 years ago
profile-sshagent.sh chokes on spaces in $HOME
Categories
(Firefox Build System :: MozillaBuild, task)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: swsnyder, Assigned: swsnyder)
References
Details
Attachments
(2 files)
783 bytes,
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
973 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
In MozillaBuild v1.2 the environment variable SSH_ENV is mis-interpreted due to the HOME env var being mishandled earlier in the script. Example, user's perspective: $ sh /c/mozilla-build/msys/etc/profile.d/profile-sshagent.sh /c/mozilla-build/msys/etc/profile.d/profile-sshagent.sh.original: /c/Documents and Settings/Steve Snyder/.ssh/environment: No such file or directory chmod: cannot access `/c/Documents': No such file or directory chmod: cannot access `and': No such file or directory chmod: cannot access `Settings/Steve': No such file or directory chmod: cannot access `Snyder/.ssh/environment': No such file or directory /c/mozilla-build/msys/etc/profile.d/profile-sshagent.sh.original: /c/Documents: No such file or directory Example, what it's actually doing:
Assignee | ||
Comment 1•17 years ago
|
||
Oops! Forgot to paste that last section of text. Example, what it's actually doing: $ sh -x /c/mozilla-build/msys/etc/profile.d/profile-sshagent.sh + SSH_ENV=/c/Documents and Settings/Steve Snyder/.ssh/environment + '[' -f '/c/Documents and Settings/Steve Snyder/.ssh/environment' ']' + start_agent + ssh-agent + sed 's/^echo/#echo/' /c/mozilla-build/msys/etc/profile.d/profile-sshagent.sh: /c/Documents and Settings/Steve Snyder/.ssh/environment: No such file or directory + chmod 600 /c/Documents and Settings/Steve Snyder/.ssh/environment chmod: cannot access `/c/Documents': No such file or directory chmod: cannot access `and': No such file or directory chmod: cannot access `Settings/Steve': No such file or directory chmod: cannot access `Snyder/.ssh/environment': No such file or directory + . /c/Documents and Settings/Steve Snyder/.ssh/environment /c/mozilla-build/msys/etc/profile.d/profile-sshagent.sh: /c/Documents: No such file or directory
Comment 2•17 years ago
|
||
Comment on attachment 294363 [details] [diff] [review] [checked in] Add quotes to ensure that env vars are handled correctly Thanks for the fix Steve, we appreciate it. AFAIK the default ~/ for MozillaBuild is, ex, c:\mozilla-build\msys\home, so I think we'll leave this for MozillaBuild 1.3.
Attachment #294363 -
Flags: review+
Comment 3•16 years ago
|
||
Checking in profile-sshagent.sh; /cvsroot/mozilla/tools/build-environment/win32/profile-sshagent.sh,v <-- profile-sshagent.sh new revision: 1.2; previous revision: 1.1 done
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 4•16 years ago
|
||
A quoting of $SSH_ENV was missed in this patch; and there's other error handling to be done. Patch upcoming.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•16 years ago
|
Attachment #294363 -
Attachment description: Add quotes to ensure that env vars are handled correctly → [checked in] Add quotes to ensure that env vars are handled correctly
Comment 5•16 years ago
|
||
Attachment #295239 -
Flags: review?(ted.mielczarek)
Updated•16 years ago
|
Attachment #295239 -
Flags: review?(ted.mielczarek) → review+
Comment 6•16 years ago
|
||
Comment on attachment 295239 [details] [diff] [review] [checked in] quote the last ${SSH_ENV}, don't try to start if ~/.ssh doesn't exist Checking in profile-sshagent.sh; /cvsroot/mozilla/tools/build-environment/win32/profile-sshagent.sh,v <-- profile-sshagent.sh new revision: 1.3; previous revision: 1.2 done
Attachment #295239 -
Attachment description: quote the last ${SSH_ENV}, don't try to start if ~/.ssh doesn't exist → [checked in] quote the last ${SSH_ENV}, don't try to start if ~/.ssh doesn't exist
Updated•16 years ago
|
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Updated•11 months ago
|
Product: mozilla.org → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•