409578 - Clean-up some compile warnings under widget/src/gtk2

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Reed Loden [:reed]]

Attachment: patch - v1

This fixes the following compile warnings:

/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp: In member function ‘virtual nsresult nsLookAndFeel::GetMetric(nsILookAndFeel::nsMetricID, PRInt32&)’:
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_WindowTitleHeight’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_WindowBorderWidth’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_WindowBorderHeight’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_Widget3DBorder’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_TextFieldBorder’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_TextFieldHeight’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_TextVerticalInsidePadding’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_TextShouldUseVerticalInsidePadding’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_TextHorizontalInsideMinimumPadding’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_TextShouldUseHorizontalInsideMinimumPadding’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_ButtonHorizontalInsidePaddingNavQuirks’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_ButtonHorizontalInsidePaddingOffsetNavQuirks’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_CheckboxSize’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_RadioboxSize’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_ListShouldUseHorizontalInsideMinimumPadding’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_ListHorizontalInsideMinimumPadding’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_ListShouldUseVerticalInsidePadding’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_ListVerticalInsidePadding’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_CaretBlinkTime’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_CaretWidth’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_ShowCaretDuringSelection’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_SelectTextfieldsOnKeyFocus’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_SubmenuDelay’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_MenusCanOverlapOSBar’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_SkipNavigatingDisabledMenuItem’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_DragFullWindow’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_DragThresholdX’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_DragThresholdY’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_UseAccessibilityTheme’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_IsScreenReaderActive’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_ScrollArrowStyle’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_ScrollSliderStyle’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_TreeOpenDelay’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_TreeCloseDelay’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_TreeLazyScrollDelay’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_TreeScrollDelay’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_TreeScrollLinesMax’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_TabFocusModel’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_AlertNotificationOrigin’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_ScrollToClick’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_IMERawInputUnderlineStyle’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_IMESelectedRawTextUnderlineStyle’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_IMEConvertedTextUnderlineStyle’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsLookAndFeel.cpp:340: warning: enumeration value ‘eMetric_IMESelectedConvertedTextUnderline’ not handled in switch
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsGtkKeyUtils.cpp: In function ‘int DOMKeyCodeToGdkKeyCode(PRUint32)’:
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsGtkKeyUtils.cpp:244: warning: comparison between signed and unsigned integer expressions
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsWindow.cpp: In member function ‘void nsWindow::ResizeTransparencyBitmap(PRInt32, PRInt32)’:
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsWindow.cpp:3533: warning: comparison between signed and unsigned integer expressions
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsWindow.cpp:3534: warning: comparison between signed and unsigned integer expressions
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsWindow.cpp:3550: warning: comparison between signed and unsigned integer expressions
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsWindow.cpp:3551: warning: comparison between signed and unsigned integer expressions
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsWindow.cpp: In member function ‘virtual nsresult nsWindow::GetToggledKeyState(PRUint32, PRBool*)’:
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsWindow.cpp:5765: warning: unused variable ‘foundMasks’
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsPrintJobGTK.cpp: In member function ‘virtual nsresult nsPrintJobPipeGTK::Submit()’:
/home/reed/mozilla/builds/mozilla/widget/src/gtk2/nsPrintJobGTK.cpp:267: warning: ‘destPipe’ may be used uninitialized in this function

There are others, but this fixes a lot of the ones that fill half my screen when compiling.

Comment 1

[Reed Loden [:reed]]

Comment on attachment 294384 [details] [diff] [review]
patch - v1

Just removes some compiler warnings that make it hard to debug actual problems.

Comment 2

[Reed Loden [:reed]]

Checking in widget/src/gtk2/nsGtkKeyUtils.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsGtkKeyUtils.cpp,v  <--  nsGtkKeyUtils.cpp
new revision: 1.13; previous revision: 1.12
done
Checking in widget/src/gtk2/nsGtkKeyUtils.h;
/cvsroot/mozilla/widget/src/gtk2/nsGtkKeyUtils.h,v  <--  nsGtkKeyUtils.h
new revision: 1.5; previous revision: 1.4
done
Checking in widget/src/gtk2/nsLookAndFeel.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsLookAndFeel.cpp,v  <--  nsLookAndFeel.cpp
new revision: 1.35; previous revision: 1.34
done
Checking in widget/src/gtk2/nsPrintJobGTK.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsPrintJobGTK.cpp,v  <--  nsPrintJobGTK.cpp
new revision: 1.4; previous revision: 1.3
done
Checking in widget/src/gtk2/nsWindow.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.246; previous revision: 1.245
done
Checking in widget/src/gtk2/nsWindow.h;
/cvsroot/mozilla/widget/src/gtk2/nsWindow.h,v  <--  nsWindow.h
new revision: 1.83; previous revision: 1.82
done

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 294384 [details] [diff] [review]
patch - v1

>     PRBool foundMasks = gdk_keyboard_get_modmap_masks(
>                           GDK_WINDOW_XDISPLAY(mDrawingarea->inner_window),
>                           &capsLockMask, &numLockMask, &scrollLockMask);
>+    if (!foundMasks)
>+        return NS_ERROR_NOT_IMPLEMENTED;

foundMasks doesn't seem like the right name for an error return.

Comment 4

[Reed Loden [:reed]]

(In reply to comment #3)
> (From update of attachment 294384 [details] [diff] [review])
> >     PRBool foundMasks = gdk_keyboard_get_modmap_masks(
> >                           GDK_WINDOW_XDISPLAY(mDrawingarea->inner_window),
> >                           &capsLockMask, &numLockMask, &scrollLockMask);
> >+    if (!foundMasks)
> >+        return NS_ERROR_NOT_IMPLEMENTED;
> 
> foundMasks doesn't seem like the right name for an error return.

What name should it be then? I didn't name it... just was using it. Note that the |if (mask == 0)| check returns the same error code several lines below this.