409607 - Don't re-collect AIM screen name if a card for the user already exists

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

I'm sure I've seen a bug or comment about this somewhere, but I can't find it after several searches.

Currently if the user sends an email to one of the "special" domains (netscape.net, cs.com, aol.com) the screen name will be collected from the first part of their email when collecting the card to the address book.

If the card already exists in the address book, and the screen name is blank, then we'll re-collect the screen name.

This seems a bit pointless - if we've already collected the name once, and the user doesn't want it and has blanked it out, then we'll collect it again. If they've done it by mistake, then they should be able to derive it from the email, but I don't see that being a common case.

So I think in the card already existing case the code is a bit pointless, and we should just drop it - attaching patch.

Note there's some extra tidy up that can be done, but I want to do that in a follow-up bug.

Comment 1

[[e-mail]]

Comment on attachment 294410 [details] [diff] [review]
The fix

>-      rv = AutoCollectScreenName(existingCard, nsCString(curAddress), &setScreenName);
The other caller of this function doesn't use the setScreenName parameter, so you could remove it...

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> (From update of attachment 294410 [details] [diff] [review])
> >-      rv = AutoCollectScreenName(existingCard, nsCString(curAddress), &setScreenName);
> The other caller of this function doesn't use the setScreenName parameter, so
> you could remove it...

I'll fix that in the follow up bug 409608.

Patch checked in -> fixed.